-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ProductVariantPrice custom fields ui inputs #3263
Add ProductVariantPrice custom fields ui inputs #3263
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I have read the CLA Document and I hereby sign the CLA 12 out of 13 committers have signed the CLA. |
.../src/lib/catalog/src/components/product-variant-detail/product-variant-detail.component.html
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Relates to vendure-ecommerce#3247. This commit implements the approach of deriving a unique port number based on the index of the current test file in its parent directory.
The "docs" branch is no longer used, so the index was not getting updated.
Hi Kevin! Let's get this one merged. You'll just need to:
I don't know why the CLA bot is unhappy but you definitely signed it so that won't be a blocker. |
Hi @Draykee, thanks for you work, i need this feature, can i fix your pull request? :D |
I just can't get it working, because of husky. Crazy how simple git merges always turn out to be the most troublesome. |
…' into feat/product-variant-price-cf-ui # Conflicts: # package-lock.json # schema-admin.json # schema-shop.json
Ups.. @michaelbromley I think I made it worse 😅 |
Quality Gate passedIssues Measures |
Description
Closes: Expose admin-ui for custom fields on ProductVariantPrice. #3020
Breaking changes
The admin-api schema needs to be updated. The Typescript should not break though, so it should be safe to update.
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
👍 Most of the time: