Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProductVariantPrice custom fields ui inputs #3263

Conversation

Draykee
Copy link
Contributor

@Draykee Draykee commented Dec 6, 2024

Description

Breaking changes

The admin-api schema needs to be updated. The Typescript should not break though, so it should be safe to update.

Screenshots

You can add screenshots here if applicable.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 21, 2025 2:38pm

Copy link
Contributor

github-actions bot commented Dec 6, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


12 out of 13 committers have signed the CLA.
✅ (oidt)[https://github.com/oidt]
✅ (michaelbromley)[https://github.com/michaelbromley]
✅ (Anddrrew)[https://github.com/Anddrrew]
✅ (mschipperheyn)[https://github.com/mschipperheyn]
✅ (twlite)[https://github.com/twlite]
✅ (jezzzm)[https://github.com/jezzzm]
✅ (xtul9)[https://github.com/xtul9]
✅ (jacobfrantz1)[https://github.com/jacobfrantz1]
✅ (Winne4r)[https://github.com/Winne4r]
✅ (HerclasNido)[https://github.com/HerclasNido]
✅ (dlhck)[https://github.com/dlhck]
✅ (Draykee)[https://github.com/Draykee]
@kevin
Kevin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@Draykee Draykee changed the title (WIP) Added ProductVariantPrice custom fields ui inputs (WIP) Added ProductVariantPrice custom fields ui inputs (#3020) Dec 6, 2024
@Draykee
Copy link
Contributor Author

Draykee commented Dec 6, 2024

image
TODO: Improve the card and blend it into the current design

Copy link

sonarqubecloud bot commented Dec 6, 2024

@Draykee Draykee changed the title (WIP) Added ProductVariantPrice custom fields ui inputs (#3020) Add ProductVariantPrice custom fields ui inputs Dec 6, 2024
github-actions bot and others added 19 commits December 9, 2024 07:59
Relates to vendure-ecommerce#3247. This commit implements the approach of deriving
a unique port number based on the index of the current test file
in its parent directory.
The "docs" branch is no longer used, so the index was not getting
updated.
@michaelbromley
Copy link
Member

Hi Kevin!

Let's get this one merged. You'll just need to:

  1. resolve the merge conflicts
  2. regenerate the gql types but without the custom fields

I don't know why the CLA bot is unhappy but you definitely signed it so that won't be a blocker.

@dfernandesbsolus
Copy link
Contributor

Hi @Draykee, thanks for you work, i need this feature, can i fix your pull request? :D

@Draykee
Copy link
Contributor Author

Draykee commented Jan 21, 2025

I just can't get it working, because of husky. Crazy how simple git merges always turn out to be the most troublesome.

@Draykee
Copy link
Contributor Author

Draykee commented Jan 21, 2025

I just can't get it working, because of husky. Crazy how simple git merges always turn out to be the most troublesome.

Ups.. @michaelbromley I think I made it worse 😅

@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose admin-ui for custom fields on ProductVariantPrice.