fix: add support for mac's command key for selection manager #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
All contributors have signed the CLA ✍️ ✅ |
rein1410
changed the title
rein1410
changed the title
|
|
Thanks for the contribution! This looks good. Before I can merge this, you'll need to sign the CLA as directed in this comment: #3315 (comment) And also can you make the PR against the |
|
I have read the CLA Document and I hereby sign the CLA |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Selection manager was missing support for multiple selection with the mac's command key, causing Mac users unable to select images one by one. since holding control on Mac opens the right click menu on chrome based browsers.
Breaking changes
No
Checklist
📌 Always:
👍 Most of the time: