Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueTriple has "measurements" should be "measurement" to match corim draft #123

Closed
deeglaze opened this issue Aug 9, 2024 · 5 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@deeglaze
Copy link
Collaborator

deeglaze commented Aug 9, 2024

The reference-triple-record has 1 environment-map and 1 measurement-map. The ValueTriple's "measurements" collection does not follow that document structure, so I don't know how this produces a valid comid.

It would certainly seem to me that 1 environment could have multiple measurements of different names and value kinds the way this code allows for, but the draft doesn't allow for that. The mkey I thought was a way for multiplicity to be allowed, but also no.

@setrofim setrofim added the bug Something isn't working label Aug 9, 2024
@setrofim
Copy link
Contributor

setrofim commented Aug 9, 2024

Looks like the code matches rev00 of the draft, and the triples structure was never brought into alignment with the later versions. We need to fix this.

@thomas-fossati
Copy link
Contributor

Noting that this change would impact how PSA and CCA reference values are currently encoded.

@setrofim
Copy link
Contributor

setrofim commented Aug 9, 2024

Noting that this change would impact how PSA and CCA reference values are currently encoded.

Yup, this will have ripple effect on a lot of existing code. Fixing this is not going to be trivial...

@setrofim setrofim self-assigned this Aug 13, 2024
@yogeshbdeshpande
Copy link
Contributor

Yes, this was a known issue however, we had not scoped it fully so had put on hold for a while.

Has impact on PSA, CCA and also Parsec-CCA Scheme under Veraison

@setrofim
Copy link
Contributor

@deeglaze this should be resolved by #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants