Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content Type in COSE_Sign1 out of spec #132

Open
deeglaze opened this issue Oct 24, 2024 · 1 comment
Open

Content Type in COSE_Sign1 out of spec #132

deeglaze opened this issue Oct 24, 2024 · 1 comment
Labels
invalid This doesn't seem right

Comments

@deeglaze
Copy link
Collaborator

application/corim-unsigned+cbor is the expected content type, but signedcorim.go specifies application/rim+cbor.
deeglaze added a commit to deeglaze/corim that referenced this issue Oct 25, 2024
@deeglaze
Cut veraison#6.500, veraison#6.502 in FromCOSE
e6351ec 
Top level tags are not interpretable as a COSE object.
The protected header content-type is not meant to be
application/rim+cbor according to the spec draft (Issue veraison#132).

Support the spec's optional unsigned corim tag in COSE payload.

Signed-off-by: Dionna Glaze <[email protected]>
@deeglaze deeglaze mentioned this issue Oct 25, 2024
Merged
deeglaze added a commit to deeglaze/corim that referenced this issue Oct 29, 2024
@deeglaze
Cut veraison#6.500, veraison#6.502 in FromCOSE
b5496cc 
Top level tags are not interpretable as a COSE object.
The protected header content-type is not meant to be
application/rim+cbor according to the spec draft (Issue veraison#132).

Support the spec's optional unsigned corim tag in COSE payload.

Signed-off-by: Dionna Glaze <[email protected]>
deeglaze added a commit to deeglaze/corim that referenced this issue Oct 29, 2024
@deeglaze
Cut veraison#6.500, veraison#6.502 in FromCOSE
6621414 
Top level tags are not interpretable as a COSE object.
The protected header content-type is not meant to be
application/rim+cbor according to the spec draft (Issue veraison#132).

Support the spec's optional unsigned corim tag in COSE payload.

Signed-off-by: Dionna Glaze <[email protected]>
@deeglaze
Copy link
Collaborator Author

CoRIM spec PR#337 should resolve this as a nonissue for this library.

@deeglaze deeglaze added the invalid This doesn't seem right label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@deeglaze