Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoRIM Extensions: Consider a suitable name for Profile Structure #135

Open
yogeshbdeshpande opened this issue Dec 9, 2024 · 1 comment · May be fixed by #140
Open

CoRIM Extensions: Consider a suitable name for Profile Structure #135

yogeshbdeshpande opened this issue Dec 9, 2024 · 1 comment · May be fixed by #140

Comments

@yogeshbdeshpande
Copy link
Contributor

In the current code base there is a Name Collision.

EAT.profile which is infact a ProfileID, is used consistently with the variable name profile

However in the same code base there is a Profile struct which is also referenced as Profile

This causes name collision.

Suggest a suitable name for Profile Structure as: ProfileInfo or ProfileManifest
@Priyanshuthapliyal2005 Priyanshuthapliyal2005 linked a pull request Dec 24, 2024 that will close this issue
Open
@deeglaze
Copy link
Collaborator

Why does CoRIM use an EAT profile? They’re different standards. An identifier type should have ID in the name. Following other reflection library conventions, I’d represent the meaning of a profile with a “ProfileDescriptor”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@deeglaze @yogeshbdeshpande