You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
yogeshbdeshpande
changed the title
Need to disable usage of copyright header script in CI Pipeline for Integration Tests
Copyright header script needs to be disabled in CI Pipeline for Integration Tests
Mar 15, 2024
Cpyright checks are only run as part of make test, and so are not typically triggered during integration tests (make integ-test). However, scheme/common/Makefile contained a pre hook that ran make -C ../../handler. Since this did not specify a target, it triggered the default goal of test. This causes tests and copyright checks to run for handler/ when shemes are built (not tested!). That means that the copyright check is triggered during Docker deployment creation in the integration tests pipeline.
The pre hook is unncessary (or maybe no longer necessary -- it seems to be inhereted from the old code line and its unclear why it was originally added), and is removed in #217
The integration tests when run in CI, checks for Copyright Headers.
Need to disable the same in Integration Tests, as the current Step of Checkout Code:
/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +d55b0617a90c0a9f522e48d148893958d7900664:refs/remotes/origin/realm-provisioning-v2
Checks-out assuming a new branch! This detects a Copyright Header for files which have not been modified.!
A change has been done in the
CI Test
via a fix in ci.yml using PR #211A similar fix is needed in integration-tests.yml
The text was updated successfully, but these errors were encountered: