Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright header script needs to be disabled in CI Pipeline for Integration Tests #212

Closed
yogeshbdeshpande opened this issue Mar 15, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@yogeshbdeshpande
Copy link
Collaborator

The integration tests when run in CI, checks for Copyright Headers.

Need to disable the same in Integration Tests, as the current Step of Checkout Code:

/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +d55b0617a90c0a9f522e48d148893958d7900664:refs/remotes/origin/realm-provisioning-v2

Checks-out assuming a new branch! This detects a Copyright Header for files which have not been modified.!

A change has been done in the CI Test via a fix in ci.yml using PR #211
A similar fix is needed in integration-tests.yml

@yogeshbdeshpande yogeshbdeshpande added the bug Something isn't working label Mar 15, 2024
@yogeshbdeshpande yogeshbdeshpande changed the title Need to disable usage of copyright header script in CI Pipeline for Integration Tests Copyright header script needs to be disabled in CI Pipeline for Integration Tests Mar 15, 2024
@setrofim
Copy link
Collaborator

This problem is actually confined to handler/.

Cpyright checks are only run as part of make test, and so are not typically triggered during integration tests (make integ-test). However, scheme/common/Makefile contained a pre hook that ran make -C ../../handler. Since this did not specify a target, it triggered the default goal of test. This causes tests and copyright checks to run for handler/ when shemes are built (not tested!). That means that the copyright check is triggered during Docker deployment creation in the integration tests pipeline.

The pre hook is unncessary (or maybe no longer necessary -- it seems to be inhereted from the old code line and its unclear why it was originally added), and is removed in #217

@setrofim
Copy link
Collaborator

Resolved by #217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants