Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: In-Loop Replacement #3

Open
mboyas-mitre opened this issue Dec 11, 2018 · 1 comment
Open

Enhancement: In-Loop Replacement #3

mboyas-mitre opened this issue Dec 11, 2018 · 1 comment

Comments

@mboyas-mitre
Copy link
Contributor

https://github.com/verbal-autopsy-software/InterVA4/blob/792fd94fcad1f143f55865e580a4ea0bc233e5bb/InterVA4_1.7/R/InterVA.R#L288-291

These lines are converting categorical to binary on a line-by-line basis. It might be easier (and likely more efficient) to move this operation outside of the for loop and convert the entire input dataset at once.

@richardli
Copy link
Collaborator

agree, only doing this because of replication from the InterVA software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants