Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing a tab results in a blank screen #8032

Open
2 tasks done
philip-peterson opened this issue Sep 2, 2024 · 1 comment · May be fixed by #8051 or corneliusroemer/hyper#78
Open
2 tasks done

Closing a tab results in a blank screen #8032

philip-peterson opened this issue Sep 2, 2024 · 1 comment · May be fixed by #8051 or corneliusroemer/hyper#78

Comments

@philip-peterson
Copy link

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Mac OS 14.4.1 Sonoma
  • Hyper.app version: 2a7bb18
  • Link of a Gist with the contents of your hyper.json: N/A
  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):
<embedded>:23937 Uncaught TypeError: Cannot read properties of undefined (reading 'onRequestRedraw')
    at t.RenderService.setRenderer (<embedded>:23937:107471)
    at Object.dispose (<embedded>:23933:91675)
    at a.dispose (<embedded>:23933:74208)
    at t.AddonManager._wrappedAddonDispose (<embedded>:23937:253461)
    at t.dispose (<embedded>:23937:253188)
    at t.AddonManager.dispose (<embedded>:23937:253070)
    at d.dispose (<embedded>:23937:190098)
    at d.dispose (<embedded>:23937:282496)
    at Terms.componentDidUpdate (terms.tsx:65:1)
    at commitLayoutEffectOnFiber (<embedded>:50695:36)

The above error occurred in the <Terms> component:

    at Terms (file:///Users/ironmagma/Code/hyper/target/renderer/bundle.js:4796:5)
    at DecoratedComponent (file:///Users/ironmagma/Code/hyper/target/renderer/bundle.js:2254:7)
    at ConnectFunction (<embedded>:57692:80)
    at forwardConnectRef
    at div
    at div
    at file:///Users/ironmagma/Code/hyper/target/renderer/bundle.js:1410:66
    at DecoratedComponent (file:///Users/ironmagma/Code/hyper/target/renderer/bundle.js:2192:7)
    at DecoratedComponent (file:///Users/ironmagma/Code/hyper/target/renderer/bundle.js:2254:7)
    at ConnectFunction (<embedded>:57692:80)
    at forwardConnectRef
    at Provider (<embedded>:63116:9)

React will try to recreate this component tree from scratch using the error boundary you provided, DecoratedComponent.
  • The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

Closing a tab with CMD-W (or Shell > Close) results in a blank screen. This occurs on canary but not v4.0.0-canary.5.

@philip-peterson
Copy link
Author

This appears to be new since 632a110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant