Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPR causes key prop warning with Parallel Routes #70452

Closed
Marukome0743 opened this issue Sep 25, 2024 · 2 comments
Closed

PPR causes key prop warning with Parallel Routes #70452

Marukome0743 opened this issue Sep 25, 2024 · 2 comments
Labels
bug Issue was opened via the bug report template. locked Parallel & Intercepting Routes Related to Parallel and/or Intercepting routes. Partial Prerendering (PPR) Related to Partial Prerendering.

Comments

@Marukome0743
Copy link
Contributor

Marukome0743 commented Sep 25, 2024

Link to the code that reproduces this issue

https://github.com/Marukome0743/ppr_unique_key_error

To Reproduce

  1. Add ppr: "incremental" option to next.config.mjs.
  2. Create Slots folder such as @auth.
  3. Start the application in development (next dev).
  4. The below warning message will appear in console.
    Each child in a list should have a unique "key" prop. See https://react.dev/link/warning-keys for more information.

Current vs. Expected behavior

Current

Each child in a list should have a unique "key" prop. See https://react.dev/link/warning-keys for more information. shows.

Expected

No warnings.

Provide environment information

Operating System:
  Platform: linux
  Arch: x64
  Version: #1 SMP Fri Mar 29 23:14:13 UTC 2024
  Available memory (MB): 15885
  Available CPU cores: 8
Binaries:
  Node: 22.9.0
  npm: 10.8.3
  Yarn: N/A
  pnpm: N/A
Relevant Packages:
  next: 15.0.0-canary.167 // Latest available version is detected (15.0.0-canary.167).
  eslint-config-next: N/A
  react: 19.0.0-rc-5d19e1c8-20240923
  react-dom: 19.0.0-rc-5d19e1c8-20240923
  typescript: 5.3.3
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

Parallel & Intercepting Routes, Partial Prerendering (PPR)

Which stage(s) are affected? (Select all that apply)

next dev (local)

Additional context

I tested my reproduction against different canary releases, and the first one that introduced the warning was 15.0.0-canary.163, since reverting to 15.0.0-canary.162 works.

Note

The last canary release (15.0.0-canary.167) workflow failed.
That causes mismatching @next/swc version error at canary.
Then temporarily check 15.0.0-canary.166 version instead of canary.

@Marukome0743 Marukome0743 added the bug Issue was opened via the bug report template. label Sep 25, 2024
@github-actions github-actions bot added Parallel & Intercepting Routes Related to Parallel and/or Intercepting routes. Partial Prerendering (PPR) Related to Partial Prerendering. labels Sep 25, 2024
@Marukome0743 Marukome0743 changed the title PPR causes key prop error with Parallel Routes PPR causes key prop warning with Parallel Routes Sep 25, 2024
@Marukome0743
Copy link
Contributor Author

Fixed: #70807

Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. locked Parallel & Intercepting Routes Related to Parallel and/or Intercepting routes. Partial Prerendering (PPR) Related to Partial Prerendering.
Projects
None yet
Development

No branches or pull requests

1 participant