Fix Accessing element.ref was removed in React 19

[oliviertassinari]

See https://codesandbox.io/p/devbox/muddy-http-h3r423?file=%2Fpages%2Findex.tsx%3A12%2C5&workspaceId=ws_JTzKEPRDQXMzzhKd3x4aSM as a reproduction of the problem

import NextLink from "next/link";

const ref = { current: null };

export default function Index() {
  return (
    <div>
      <NextLink href="/bar" legacyBehavior>
        <a ref={ref}>Link fail</a>
      </NextLink>
    </div>
  );
}

---

Context #72873 (comment) doesn't look accurate. However, going to https://github.com/mui/material-ui/tree/master/examples/material-ui-nextjs-pages-router and opening the /about page is enough to reproduce the problem.

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: a089535

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[oliviertassinari]

I wasn't sure how you guys want to check this, another option is:

Suggested change

	if (parseInt(React.version, 10) >= 19) {
	if ((element.props as any).propertyIsEnumerable('ref')) {

[eps1lon]

Object.prototype.propertyIsEnumerable.call(element.props, 'ref') is preferable.

[eps1lon]

Actually, let's just use the one Radix-UI uses. That one is tested already: https://github.com/radix-ui/primitives/blob/dae8ef4920b45f736e2574abf23676efab103645/packages/react/presence/src/Presence.tsx#L173-L190

[oliviertassinari]

No objections. Maybe not ideal for bundle size though? radix-ui/primitives#2934 (comment).

Material-UI used: https://github.com/mui/material-ui/pull/43132/files#diff-2aabece439eee5bb9309cc46b1b3c3b690ee8a7231cbac1ba495cf832e506152R16 until it changed to copy Base UI to reduce bundle size.
Base UI uses: https://github.com/mui/base-ui/blob/a14ea0e7600e99a9c052978ee916e3348638b796/packages/react/src/utils/getReactElementRef.ts#L12

[eps1lon]

Testing for React.version is not robust. Feature detection is always preferable. And in that regard the one in Radix UI is actually battle tested. We can optimize later for implementations that have been tested against the full support matrix.

[eps1lon]

codesandbox.io/p/devbox/muddy-http-h3r423?file=%2Fpages%2Findex.tsx%3A14%2C1&workspaceId=ws_JTzKEPRDQXMzzhKd3x4aSM

Seems private. Gives me a 404.

[oliviertassinari]

Seems private. Gives me a 404.

Oops, fixed.