Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try ci #74554

Draft
wants to merge 90 commits into
base: canary
Choose a base branch
from
Draft

try ci #74554

wants to merge 90 commits into from
+3,114 −509

Conversation

hardfist
Copy link

@hardfist hardfist commented Jan 6, 2025

No description provided.

@hardfist hardfist changed the title try run test in ci try ci Jan 6, 2025
@feedthejim feedthejim added the CI approved Approve running CI for fork label Jan 6, 2025
@feedthejim feedthejim marked this pull request as ready for review January 6, 2025 16:07
@feedthejim feedthejim marked this pull request as draft January 6, 2025 16:07
@socket-security Socket Security
Copy link

socket-security bot commented Jan 6, 2025 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@rspack-canary/[email protected] environment, eval, filesystem, network, shell, unsafe +8 2.7 MB hardfist
npm/@rspack/[email protected] environment, eval 0 86.7 kB harpsealjs

View full report↗︎

@ijjk
Copy link
Member

ijjk commented Jan 6, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary hardfist/next.js yj/try-ci-test Change
buildDuration 22.2s 18.4s N/A
buildDurationCached 17.2s 14.7s N/A
nodeModulesSize 392 MB 3.79 GB ⚠️ +3.4 GB
nextStartRea..uration (ms) 477ms 474ms N/A
Client Bundles (main, webpack)
vercel/next.js canary hardfist/next.js yj/try-ci-test Change
5306-HASH.js gzip 54 kB 53.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB ✓
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary hardfist/next.js yj/try-ci-test Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary hardfist/next.js yj/try-ci-test Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary hardfist/next.js yj/try-ci-test Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary hardfist/next.js yj/try-ci-test Change
index.html gzip 523 B 523 B ✓
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 523 B 523 B ✓
Edge SSR bundle Size
vercel/next.js canary hardfist/next.js yj/try-ci-test Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary hardfist/next.js yj/try-ci-test Change
middleware-b..fest.js gzip 668 B 665 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes Overall increase ⚠️
vercel/next.js canary hardfist/next.js yj/try-ci-test Change
app-page-exp...dev.js gzip 386 kB 386 kB ⚠️ +174 B
app-page-exp..prod.js gzip 131 kB 131 kB N/A
app-page-tur..prod.js gzip 144 kB 144 kB N/A
app-page-tur..prod.js gzip 140 kB 140 kB N/A
app-page.run...dev.js gzip 373 kB 374 kB ⚠️ +191 B
app-page.run..prod.js gzip 128 kB 128 kB N/A
app-route-ex...dev.js gzip 39.4 kB 39.4 kB ✓
app-route-ex..prod.js gzip 25 kB 25 kB ✓
app-route-tu..prod.js gzip 25 kB 25 kB ✓
app-route-tu..prod.js gzip 24.8 kB 24.8 kB ✓
app-route.ru...dev.js gzip 41 kB 41 kB ✓
app-route.ru..prod.js gzip 24.8 kB 24.8 kB ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
pages-api-tu..prod.js gzip 8.81 kB 8.81 kB ✓
pages-api.ru...dev.js gzip 11.5 kB 11.5 kB ✓
pages-api.ru..prod.js gzip 8.8 kB 8.8 kB ✓
pages-turbo...prod.js gzip 21.6 kB 21.6 kB N/A
pages.runtim...dev.js gzip 31.3 kB 31.4 kB N/A
pages.runtim..prod.js gzip 21.6 kB 21.6 kB N/A
server.runti..prod.js gzip 73.7 kB 73.7 kB N/A
Overall change 969 kB 970 kB ⚠️ +365 B
build cache Overall increase ⚠️
vercel/next.js canary hardfist/next.js yj/try-ci-test Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +4.61 kB
index.pack gzip 75.7 kB 75.1 kB N/A
Overall change 2.1 MB 2.1 MB ⚠️ +4.61 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js 
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for pages-turbo...time.prod.js

Diff too large to display

Diff for pages.runtime.dev.js

Diff too large to display

Diff for pages.runtime.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: 0fe5e2d

ijjk added 7 commits January 6, 2025 08:46
@ijjk
set rspack env and disable turbopack ones
aa4d3a8
@ijjk
other config
e7ba190
@ijjk
use normal dependencies
d974b31
@ijjk
Merge branch 'ijjk/benchmark' into yj/try-ci-test
f10222f 
# Conflicts:
#	packages/next/package.json
#	packages/next/src/build/compiler.ts
#	packages/next/src/build/webpack-config.ts
#	packages/next/src/build/webpack/plugins/middleware-plugin.ts
#	packages/next/src/compiled/webpack/webpack.js
#	pnpm-lock.yaml
@ijjk
only return jsconfig if exists
b38ccfc
@ijjk
Merge branch 'canary' into yj/try-ci-test
da7b0a6 
# Conflicts:
#	.github/workflows/build_and_test.yml
#	.github/workflows/build_reusable.yml
#	packages/next/package.json
#	packages/next/src/build/webpack/plugins/app-build-manifest-plugin.ts
#	packages/next/src/build/webpack/plugins/flight-client-entry-plugin.ts
#	packages/next/src/build/webpack/plugins/flight-manifest-plugin.ts
#	pnpm-lock.yaml
@ijjk
lint-fix
1246b16
@matthewdavi
Copy link

this would be great since turbopack doesn't actually work after 3 years of working on it. currently working on an app that takes like 80 seconds to load the homepage. with turbo.

ahabhgk and others added 8 commits January 22, 2025 14:37
@ahabhgk
fix rspack broken
590205e
@h-a-n-a
feat: support otel for dev
45e3f6f
@ijjk
Merge branch 'canary' into yj/try-ci-test
0e0f7b9 
# Conflicts:
#	packages/next/src/server/dev/hot-reloader-webpack.ts
@ijjk
avoid overwriting trace in dev
0d5b7c8
@ijjk
Merge branch 'canary' into yj/try-ci-test
e4168ee 
# Conflicts:
#	pnpm-lock.yaml
@ijjk
fix optimize_server_react config and compiled
76f6de7
@ijjk
Merge branch 'canary' into yj/try-ci-test
9e1ed0b 
# Conflicts:
#	.github/workflows/build_and_test.yml
#	packages/next/src/compiled/sass-loader/cjs.js
#	pnpm-lock.yaml
@ijjk
fix plugin
1f0c4da
@timneutkens
Copy link
Member

@matthewdavi can you share a trace for your application: https://nextjs.org/docs/app/api-reference/turbopack#generating-trace-files so that we can have a look.

@timneutkens timneutkens mentioned this pull request Jan 29, 2025
Merged
timneutkens added a commit that referenced this pull request Jan 29, 2025
@timneutkens
Add temporary CI workflows for testing (#75432)
348c7fe 
## What?

Temporary CI workflows for #74554.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI approved Approve running CI for fork tests type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hardfist @ijjk @matthewdavi @timneutkens @feedthejim @SyMind @ahabhgk @h-a-n-a