Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mojibake in server action inputs (fixes #74843) #74845

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

vexcat
Copy link
Contributor

@vexcat vexcat commented Jan 14, 2025

Fixes #74843

@ijjk
Copy link
Member

ijjk commented Jan 14, 2025

Allow CI Workflow Run

  • approve CI run for commit: 8a2a974

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk ijjk added the tests label Jan 14, 2025
@unstubbable
Copy link
Contributor

@vexcat Thank you for the fix. I've added an e2e test that's based on your repro.

@ijjk
Copy link
Member

ijjk commented Jan 14, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vexcat/next.js vexcat/fix-edge-mojibake Change
buildDuration 17.2s 15.1s N/A
buildDurationCached 14.2s 11.8s N/A
nodeModulesSize 417 MB 417 MB ⚠️ +1.1 kB
nextStartRea..uration (ms) 416ms 424ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vexcat/next.js vexcat/fix-edge-mojibake Change
5306-HASH.js gzip 53.4 kB 53.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.2 kB 34.2 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vexcat/next.js vexcat/fix-edge-mojibake Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vexcat/next.js vexcat/fix-edge-mojibake Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vexcat/next.js vexcat/fix-edge-mojibake Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vexcat/next.js vexcat/fix-edge-mojibake Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vexcat/next.js vexcat/fix-edge-mojibake Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 207 kB 207 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vexcat/next.js vexcat/fix-edge-mojibake Change
middleware-b..fest.js gzip 670 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vexcat/next.js vexcat/fix-edge-mojibake Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 369 kB 369 kB N/A
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 357 kB 357 kB N/A
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 1.73 MB 1.73 MB
build cache Overall increase ⚠️
vercel/next.js canary vexcat/next.js vexcat/fix-edge-mojibake Change
0.pack gzip 2.09 MB 2.09 MB N/A
index.pack gzip 75.1 kB 75.4 kB ⚠️ +319 B
Overall change 75.1 kB 75.4 kB ⚠️ +319 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 208cd44

@unstubbable unstubbable added the CI approved Approve running CI for fork label Jan 14, 2025
@ijjk
Copy link
Member

ijjk commented Jan 14, 2025

Tests Passed

@unstubbable unstubbable merged commit 4a3ff85 into vercel:canary Jan 14, 2025
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI approved Approve running CI for fork tests type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-byte characters in Server Action inputs can get mangled when using the Edge Runtime
4 participants