Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix local development warnings inside next monorepo #74863

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 14, 2025

What

Follow up of #74647, do not enque warnings otherwise it's showing a message of updating tsconfig.json inside nextjs monorepo when you do pnpm next <app path>

   We detected TypeScript in your project and reconfigured your tsconfig.json file for you. Strict-mode is set to false by default.

This is because when there's action we'll always log this.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 14, 2025
@huozhi huozhi marked this pull request as ready for review January 14, 2025 14:57
@ijjk
Copy link
Member

ijjk commented Jan 14, 2025

Failing test suites

Commit: c4ff2c6

pnpm test-dev-turbo test/development/acceptance/ReactRefreshRequire.test.ts (turbopack)

  • ReactRefreshRequire > propagates hot update to all inverse dependencies
  • ReactRefreshRequire > propagates a module that stops accepting in next version
Expand output

● ReactRefreshRequire › propagates hot update to all inverse dependencies

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

  Array [
+   "init RootV1",
    "init MiddleCV2",
    "init RootV1",
  ]

  299 |       `log.push('init MiddleCV2'); export default {};`
  300 |     )
> 301 |     expect(await session.evaluate(() => (window as any).log)).toEqual([
      |                                                               ^
  302 |       'init MiddleCV2',
  303 |       'init RootV1',
  304 |     ])

  at Object.toEqual (development/acceptance/ReactRefreshRequire.test.ts:301:63)

● ReactRefreshRequire › propagates a module that stops accepting in next version

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

  Array [
    "init BarV1.1",
+   "init BarV1.1",
  ]

  399 |         `window.log.push('init BarV1.1'); export default function Bar() {};`
  400 |       ))
> 401 |     expect(await session.evaluate(() => (window as any).log)).toEqual([
      |                                                               ^
  402 |       'init BarV1.1',
  403 |     ])
  404 |

  at Object.toEqual (development/acceptance/ReactRefreshRequire.test.ts:401:63)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Jan 14, 2025

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js chore/fix-local-dev-duplicate-warning Change
buildDuration 18.6s 15.2s N/A
buildDurationCached 14.3s 12s N/A
nodeModulesSize 417 MB 417 MB ⚠️ +1.29 kB
nextStartRea..uration (ms) 426ms 417ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js chore/fix-local-dev-duplicate-warning Change
5306-HASH.js gzip 53.5 kB 53.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.2 kB 34.2 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/fix-local-dev-duplicate-warning Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js chore/fix-local-dev-duplicate-warning Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js chore/fix-local-dev-duplicate-warning Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/fix-local-dev-duplicate-warning Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js chore/fix-local-dev-duplicate-warning Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 207 kB 207 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js chore/fix-local-dev-duplicate-warning Change
middleware-b..fest.js gzip 668 B 669 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js chore/fix-local-dev-duplicate-warning Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 372 kB 372 kB
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 360 kB 360 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.46 MB 2.46 MB
build cache
vercel/next.js canary vercel/next.js chore/fix-local-dev-duplicate-warning Change
0.pack gzip 2.1 MB 2.1 MB N/A
index.pack gzip 75.9 kB 75 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: c4ff2c6

@huozhi huozhi merged commit 87bd4ec into canary Jan 14, 2025
119 of 128 checks passed
@huozhi huozhi deleted the chore/fix-local-dev-duplicate-warning branch January 14, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants