Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevOverlay] close popover/overlay on Esc #74889

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Jan 14, 2025

Closes the popover or overlay when pressing the escape key.

CleanShot.2025-01-14.at.14.48.52.mp4

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 14, 2025
Copy link
Member Author

ztanner commented Jan 14, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ztanner ztanner marked this pull request as ready for review January 14, 2025 22:51
@ztanner ztanner requested review from gaojude and devjiwonchoi and removed request for gaojude January 14, 2025 22:51
@ztanner ztanner force-pushed the 01-14-_devoverlay_close_popover_overlay_on_esc branch from eb3e0d6 to edc28ca Compare January 14, 2025 22:52
@ztanner ztanner force-pushed the 01-14-_devoverlay_close_popover_overlay_on_esc branch from edc28ca to 654485e Compare January 14, 2025 22:53
@ztanner ztanner enabled auto-merge (squash) January 14, 2025 22:55
@ijjk
Copy link
Member

ijjk commented Jan 14, 2025

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-14-_devoverlay_close_popover_overlay_on_esc Change
buildDuration 16.7s 15.1s N/A
buildDurationCached 14.3s 12.3s N/A
nodeModulesSize 418 MB 418 MB ⚠️ +13.3 kB
nextStartRea..uration (ms) 421ms 421ms
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-14-_devoverlay_close_popover_overlay_on_esc Change
5306-HASH.js gzip 53.9 kB 53.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.2 kB 34.2 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-14-_devoverlay_close_popover_overlay_on_esc Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-14-_devoverlay_close_popover_overlay_on_esc Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-14-_devoverlay_close_popover_overlay_on_esc Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-14-_devoverlay_close_popover_overlay_on_esc Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-14-_devoverlay_close_popover_overlay_on_esc Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-14-_devoverlay_close_popover_overlay_on_esc Change
middleware-b..fest.js gzip 670 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 01-14-_devoverlay_close_popover_overlay_on_esc Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 373 kB 374 kB N/A
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 361 kB 361 kB N/A
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 1.73 MB 1.73 MB
build cache
vercel/next.js canary vercel/next.js 01-14-_devoverlay_close_popover_overlay_on_esc Change
0.pack gzip 2.09 MB 2.09 MB N/A
index.pack gzip 75.4 kB 74.3 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Commit: 654485e

@ztanner ztanner merged commit 8e4b6d8 into canary Jan 14, 2025
131 checks passed
@ztanner ztanner deleted the 01-14-_devoverlay_close_popover_overlay_on_esc branch January 14, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants