-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode terminal crashing in specific case with TUI #10210
Comments
Bringing error logs that were DM'ed to me here:
|
Our current theory is that the task is writing some bad character to the terminal. We're not handling it well enough, so a crash occurs. We think there's some race condition in one of our underlying libraries but can't confirm without more information. Can you give us some information about what tools are being used in the task that is crashing? Are there any out-of-the-ordinary characters in the log output? More generally, we're looking for anything that could be atypical being written to the terminal. |
Attaching the logs for the full crash here: logs.txt (Last 2 files have been renamed from .toml to .txt) |
I can also say that this happens regardless of which terminal is used. In my team, this happens to everyone, so I had to switch to |
@anthonyshew i did some random stuff and figured out that it happens when turbo is killed the reproduction steps are: (i verified that this happens on all turborepo projects that i have, all of them are in turbo v 2.4.4).
Then try hovering the mouse over the terminal, it should go crazy. Let me know if this works. Incase it doesn't, I'll try finding some other way to reproduce. |
Original discussion: #10195
Verify canary release
Link to code that reproduces this issue
N/A
Which canary version will you have in your reproduction?
2.4.4
Environment information
Expected behavior
See additional context for information.
Actual behavior
See additional context for information.
To Reproduce
We don't have a clean reproduction for this case. See additional context for information.
Additional context
Summary
Sometimes after completing a task I get characters in the terminal or in the commit message.
Something like this:
35;95;33M35;94;33M35;94;34M35;93;34M35;93;35M35;92;35M35;91;36M35;91;37M35;90;37M35;89;37M35;89;38M35;88;38M35;88;39M35;88;40M35;88;41M35;88;42M35;88;43M
Sometimes they are there, sometimes they are not, I don't see a pattern. They can also appear after the task is completed with
git commit --amend
. In this case, all these symbols become a commit message, which requires additional changesAdditional information
Example
No response
The text was updated successfully, but these errors were encountered: