[Placement] Resolved Inconsistency with Placing at Root Tile Locs #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found an inconsistency with how the placement of cluster blocks into large tiles was handled in VPR. During placement, clusters are only placed at the rool tile location of the grid; however, specific parts of the later stages require that clusters are placed at all tile locations of large tiles. This is inconsistent and makes it confusing to know where clusters should be placed. Enforced that clusters must be placed at the root tile location and never placed in other tile locations in the large tiles. This required fixing an oversite in the flat router which was relying on the fact that clusters will not be placed at the root tile location.
|
@amin1377 This was the PR I mentioned at the VTR meeting where I fixed an oversite in the Flat Router. |
github-actions
bot
added
VPR
|
@vaughnbetz This has passed CI. Please review. This resolves the issue with the placement of clusters in large tiles that we discussed. |
vaughnbetz
approved these changes
Nov 11, 2024
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an inconsistency with how the placement of cluster blocks into large tiles was handled in VPR. During placement, clusters are only placed at the rool tile location of the grid; however, specific parts of the later stages require that clusters are placed at all tile locations of large tiles. This is inconsistent and makes it confusing to know where clusters should be placed.
Enforced that clusters must be placed at the root tile location and never placed in other tile locations in the large tiles. This required fixing an oversite in the flat router which was relying on the fact that clusters will not be placed at the root tile location.
Resolves #2801