Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default output pin utilization of logic blocks to 0.6 #2820

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

MohamedElgammal
Copy link
Contributor

Description

As shown by the attached results run by @amin1377, light packing is better for both runtime and QoR. Hence, changing the default value to 0.6

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code lang-make CMake/Make code external_libs labels Nov 21, 2024
@vaughnbetz
Copy link
Contributor

Thanks Mohamed. We'll also have to update the various nightly test golden results. If this is time critical I can merge in advance of that, but we'll need those updates very soon or no one will be able to run the nightly test, so even if we merge without them we'd need to get an update of them ASAP.

@MohamedElgammal
Copy link
Contributor Author

I just talked to Amin and I think we can land this right away. Then, he will rebase it in his branch and update the golden results for nightly tests so that we don't run it twice.

@vaughnbetz vaughnbetz merged commit 3fa3148 into master Nov 22, 2024
37 checks passed
@vaughnbetz vaughnbetz deleted the light-packing-for-logic branch November 22, 2024 20:51
@vaughnbetz
Copy link
Contributor

OK, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external_libs lang-cpp C/C++ code lang-make CMake/Make code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants