Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate the selection of candidate image widths #1

Open
verlok opened this issue Oct 31, 2022 · 0 comments
Open

Automate the selection of candidate image widths #1

verlok opened this issue Oct 31, 2022 · 0 comments

Comments

@verlok
Copy link
Owner

verlok commented Oct 31, 2022

Scenario

Currently, the npm run extract command extracts the intrinsic image widths used from the images defined in the config, and provides recommended image sizes for the responsive images that will be generated with npm run start.

The automatic recommendation though works fine only for the smallest mobile phone and not for all the devices in the resolutions.xlsx. There is still a manual process to be done for the selection of the image sizes which are best for all the resolutions.

Acceptance criteria

All the image sizes proposed by the extract algorithm and saved in the chosenImageWidth column of the data/datafile.xslx have a number close to 1.0 for the chosenRTIPixelRatio (chosen rendered-to-ideal-pixel-ratio), so that a few images dimensions are generated and reused across all resolutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant