Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.x compatibility? #38

Open
nikolasr200 opened this issue Sep 7, 2018 · 5 comments
Open

PHP 7.x compatibility? #38

nikolasr200 opened this issue Sep 7, 2018 · 5 comments

Comments

@nikolasr200
Copy link

Hi,

are there any upcoming changes regrding PHP 7.x compatibility? perhaps remove Exceptions and replace them with Throwable etc?

@nikolasr200 nikolasr200 changed the title PHP 7.x , 7.2 compatibility? PHP 7.x compatibility? Sep 7, 2018
@8odoris
Copy link

8odoris commented Sep 10, 2018

I am interested in this update. I want to use it at Yii 1.1 project.

@vernes
Copy link
Owner

vernes commented Sep 10, 2018

Hi. I'm not actively developing this anymore, but there is no reason not to at least make it compatible with 7.2. So, I'll see what I can do

@nikolasr200
Copy link
Author

Thanks a lot @vernes you ve already done a great job, and since Yii, has been updated to support PHP 7.2 it would be great to see extensions that are widely used to be updated as well. Looking forward to hearing from you.

@vernes
Copy link
Owner

vernes commented Sep 16, 2018

Do you have any specific PHP7 compatibility errors? I checked it and it works fine on php 7.2.

I don't want to introduce any breaking changes, this library is in maintenance mode and as for yii1.1, should not be used for new projects anyway.

@nikolasr200
Copy link
Author

There aren’t indeed any specific 7.2 errors as I noticed as well, just a little curious if it would worth

a) updating the exception declarence over the dummy method where email is stored as eml,
b) updating dependence with phpmailer which I think holds more deprecated exceptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants