Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - Commands available via direct calls but not via versitygw should be reported as "not implemented" #984

Open
lrm25 opened this issue Dec 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@lrm25
Copy link
Contributor

lrm25 commented Dec 12, 2024

Describe the bug
As of Dec 12 2024, there are open bugs regarding unrecognized API routes simply being routed to the root route (e.g. #899). The current solution is to implement a new routing system (#908). However, there should be a distingushing between non-existent routes for both versitygw and direct calls (such as if a user attempts to send a REST command to a gibberish route like "fjdkalj"), and routes for commands which are available via direct calls but not versitygw (such as "PutPublicAccessBlock").

To Reproduce

  1. Start versitygw, e.g.: ./versitygw --access=******** --secret=******** --region=us-east-1 --iam-dir=/Users/lukemccrone/devel/versitygw/iam --cert /Users/lukemccrone/devel/versitygw/cert.pem --key /Users/lukemccrone/devel/versitygw/versitygw.pem posix --versioning-dir /tmp/versioning /tmp/gw
  2. Create a bucket, e.g.: aws --no-verify-ssl s3api create-bucket --bucket versity-gwtest-bucket-one-1
  3. Attempt to send a command available for direct calls but not for versitygw, e.g. https://github.com/versity/versitygw/blob/test/rest_put_acl_canned/tests/rest_scripts/get_public_access_block.sh.

Expected behavior
A "not implemented" error is returned, rather than a "GET /" response.

Server Version
Version : v1.0.8
Build : 0e83322
BuildTime: 2024-12-08_01:40:15PM
Darwin Lukes-MacBook-Pro.local 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:12:25 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6030 arm64

@lrm25 lrm25 added the bug Something isn't working label Dec 12, 2024
@niksis02
Copy link
Contributor

All these routing bugs will be resolved, when we have the advanced routing system implemented . Right now, it will take a lot of effort to add checks for all the unimplemented routes. I think it requires more fundamental changes as mentioned in #908 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants