Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle CRLF normalization #50

Open
jaybosamiya opened this issue Mar 29, 2024 · 0 comments
Open

Better handle CRLF normalization #50

jaybosamiya opened this issue Mar 29, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jaybosamiya
Copy link
Collaborator

jaybosamiya commented Mar 29, 2024

If we format a properly-formatted file that has Windows newlines, then verusfmt replaces them with Unix newlines (at least on a Unix system (possibly most confusingly with WSL?)); however, this may cause confusion on verusfmt --check since literally every line will look visually identical in the diff. It would be nice if we can detect this as the reason, and provide a better error message rather than dump the whole file in the -/+ of the diff.

Core issue hit originally by @jaylorch, likely due to git's handling of newline changes.

@jaybosamiya jaybosamiya added enhancement New feature or request good first issue Good for newcomers labels Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant