Add support for broadcast proof, broadcast group, and broadcast use
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaybosamiya
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Awesome, thanks Andrea! This looks good to me.
Minor comments:
- An entry to the changelog is helpful to add as part of the PR itself; not terribly crucial since it can be added later on as part of the release process too
- The extra newline at the end of a
modis not ideal, but doesn't seem to be caused by this particular PR, so I'll just open up an issue to track that it needs to be fixed (EDIT: Unnecessary newline in same-filemodules #49)
|
Thanks!
Will keep in mind for the future! Thanks for taking care of it for me this time.
Thanks for looking into it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syntax is being introduced in verus-lang/verus#1022