Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycloak ingress annotations not being used #1839

Open
umutlelek opened this issue Aug 29, 2024 · 1 comment
Open

Keycloak ingress annotations not being used #1839

umutlelek opened this issue Aug 29, 2024 · 1 comment

Comments

@umutlelek
Copy link

How is it now?

In the file, the “ingress_annotations:” is used in the line shown below.

ingress_annotations:
cert-manager.io/cluster-issuer: "{{ keycloak_ingress_cluster_issuer }}"

However, “ keycloak_ingress_annotations: {} ” is used here.

keycloak_ingress_annotations: {}

What is our goal?

Our goal is to ensure that the configuration for Ingress annotations is used consistently and correctly in both files. We want to check that these variables are linked correctly and, if necessary, make adjustments to ensure a consistent configuration.

How do we proceed?

We proceed by adding line 103 from the tasks/main.yml to line 23 from the default/main.yml file. We also set “keycloak_ingress_annotations” in line 23 of the tasks/main.yml file. This means that the variable in “tasks” is still functional and the variable is also set in “default”.

@mnaser
Copy link
Member

mnaser commented Aug 29, 2024

Hi @umutlelek -- that's a good catch, are you able to submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants