[WiP] Fix using an existing network #469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using an existing network the patch operation fails. This change uses the correct path and values to use an existing network and subnet with magnum-cluster-api. Signed-off-by: Gabriel Adrian Samfira <[email protected]>
|
@gabriel-samfira I think we've already fixed this in #473 :) |
|
ohh! awesome! Sorry about that! I didn't try the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an existing network, the patch operation fails. This change uses the correct path and values to use an existing network and subnet with magnum-cluster-api.
Details on the broken behavior can be seen in this bug report: https://bugs.launchpad.net/kolla-ansible/+bug/2090904
Marked as WiP, as this change most likely breaks existing tests, and I will only have cycles to fix them next week.
Fixes #466