Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to skip notifications for "pre-release" #53

Open
crazy-max opened this issue Oct 29, 2018 · 7 comments
Open

Add an option to skip notifications for "pre-release" #53

crazy-max opened this issue Oct 29, 2018 · 7 comments

Comments

@crazy-max
Copy link

Hi,

Today we receive notifications for pre-release : https://github.com/brave/browser-laptop/releases/tag/v0.25.203

image

Is it possible to add an option to skip notifications for these ?

@Jacalz
Copy link

Jacalz commented Oct 31, 2018

+1 on that 👍 Especially with Brave 😅

@vfeskov
Copy link
Owner

vfeskov commented Oct 31, 2018

im basically done with this feature, you'll be able to subscribe to major & minor releases only, meaning any release that matches pattern *.*.0

i want to properly cover all the usecases with end-to-end tests before i deploy it, which will take some time, probably this week i'll finish

@crazy-max
Copy link
Author

Awesome @vfeskov ! Thanks a lot

@vfeskov
Copy link
Owner

vfeskov commented Nov 3, 2018

done, will describe in release notes

@vfeskov vfeskov closed this as completed Nov 3, 2018
@crazy-max
Copy link
Author

Hi @vfeskov, unfortunately this implementation did not solved my issue. Like I said, I was thinking to check the release status (draft, pre-release, release) :

image

Where :

  • release = !release.draft && !release.prerelease
  • prerelease = release.prerelease
  • draft = release.draft

@vfeskov vfeskov reopened this Nov 9, 2018
@vfeskov
Copy link
Owner

vfeskov commented Nov 9, 2018

thing is im not using github api because of rate limiting, im using atom feeds, e.g., https://github.com/angular/angular/releases.atom , and i think it doesn't have those flags, does it?

@crazy-max
Copy link
Author

Ok legit, I understand the limitation. And unfortunalety, you right there is no evidence for these flags in ATOM feeds 😣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants