From 31dfa091b9afa752eca079ace74320831bd8df3f Mon Sep 17 00:00:00 2001
From: vgaidarji <veaceslav.gaidarji@gmail.com>
Date: Mon, 4 Dec 2023 18:23:04 +0200
Subject: [PATCH] Remove PMD and Checkstyle from project

Project no longer contains Java code.
Will migrate over to detekt tool.
---
 app/build.gradle                              |   2 +-
 .../checkstyle/checkstyle-suppressions.xml    |  12 --
 app/config/checkstyle/checkstyle.gradle       |  54 -----
 app/config/checkstyle/checkstyle.xml          | 201 ------------------
 app/config/pmd/pmd-ruleset.xml                |  68 ------
 app/config/quality.gradle                     |  38 +---
 6 files changed, 2 insertions(+), 373 deletions(-)
 delete mode 100755 app/config/checkstyle/checkstyle-suppressions.xml
 delete mode 100755 app/config/checkstyle/checkstyle.gradle
 delete mode 100755 app/config/checkstyle/checkstyle.xml
 delete mode 100755 app/config/pmd/pmd-ruleset.xml

diff --git a/app/build.gradle b/app/build.gradle
index d32d8e6..4c59d5a 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -1,6 +1,6 @@
 apply plugin: 'com.android.application'
 apply plugin: 'org.jetbrains.kotlin.android'
-//apply from: 'config/quality.gradle'
+apply from: 'config/quality.gradle'
 apply from: 'config/jacoco.gradle'
 //apply from: 'config/coveralls.gradle'
 
diff --git a/app/config/checkstyle/checkstyle-suppressions.xml b/app/config/checkstyle/checkstyle-suppressions.xml
deleted file mode 100755
index 201feb0..0000000
--- a/app/config/checkstyle/checkstyle-suppressions.xml
+++ /dev/null
@@ -1,12 +0,0 @@
-<?xml version="1.0"?>
-<!DOCTYPE suppressions PUBLIC
-        "-//Puppy Crawl//DTD Suppressions 1.1//EN"
-        "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
-
-<suppressions>
-    <suppress files="R.java" checks="[a-zA-Z0-9]*"/>
-    <suppress files="BuildConfig.java" checks="[a-zA-Z0-9]*"/>
-    <!-- test methods names can contain "_" character -->
-    <suppress checks="MethodNameCheck" files=".*Test\.java"/>
-    <suppress checks="MagicNumber" files=".*Test\.java"/>
-</suppressions>
diff --git a/app/config/checkstyle/checkstyle.gradle b/app/config/checkstyle/checkstyle.gradle
deleted file mode 100755
index 14b8a02..0000000
--- a/app/config/checkstyle/checkstyle.gradle
+++ /dev/null
@@ -1,54 +0,0 @@
-apply plugin: 'checkstyle'
-
-checkstyle {
-    toolVersion = '7.1.2'
-}
-
-task checkstyleMain(type: Checkstyle) {
-    ignoreFailures = false
-    showViolations = true
-
-    configProperties.checkstyleSuppressionsPath =
-            file("${project.rootDir}/app/config/checkstyle/checkstyle-suppressions.xml")
-    configFile file("${project.rootDir}/app/config/checkstyle/checkstyle.xml")
-    source 'src/main/java'
-    include '**/*.java'
-    exclude '**/gen/**'
-    exclude '**/R.java'
-    exclude '**/BuildConfig.java'
-    reports {
-        xml.destination "$project.buildDir/reports/checkstyle/main.xml"
-    }
-    // empty classpath
-    classpath = files()
-}
-
-task checkstyleTest(type: Checkstyle) {
-    ignoreFailures = false
-    showViolations = true
-
-    configProperties.checkstyleSuppressionsPath =
-            file("${project.rootDir}/app/config/checkstyle/checkstyle-suppressions.xml")
-    configFile file("${project.rootDir}/app/config/checkstyle/checkstyle.xml")
-    source 'src/test/java', 'src/androidTest/java'
-    include '**/*.java'
-    exclude '**/gen/**'
-    exclude '**/R.java'
-    exclude '**/BuildConfig.java'
-    reports {
-        xml.destination "$project.buildDir/reports/checkstyle/test.xml"
-    }
-    // empty classpath
-    classpath = files()
-}
-
-task checkstyle(dependsOn: ['checkstyleMain', 'checkstyleTest']) {
-    description 'Runs Checkstyle inspection against Android sourcesets.'
-    group = 'Code Quality'
-}
-
-dependencies {
-    checkstyle('com.puppycrawl.tools:checkstyle:7.1.2')
-}
-
-preBuild.dependsOn('checkstyle')
diff --git a/app/config/checkstyle/checkstyle.xml b/app/config/checkstyle/checkstyle.xml
deleted file mode 100755
index dabcc3e..0000000
--- a/app/config/checkstyle/checkstyle.xml
+++ /dev/null
@@ -1,201 +0,0 @@
-<?xml version="1.0"?>
-<!DOCTYPE module PUBLIC
-        "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
-        "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
-
-<!-- Based on Square's config https://github.com/square/java-code-styles,
-     and Google/Sun/Checkstyle configs - https://github.com/checkstyle/checkstyle/tree/master/src/main/resources
-     Adapted by Veaceslav Gaidarji.
-
-     Initial version was based on Yopeso's Checkstyle configuration.
-     -->
-
-<module name="Checker">
-
-    <!-- We want to exclude some checkstyle checks in *Test classes -->
-    <module name="SuppressionFilter">
-        <property name="file" value="${checkstyleSuppressionsPath}"/>
-    </module>
-
-    <module name="SuppressionCommentFilter"/>
-
-    <!-- See http://checkstyle.sourceforge.net/config_misc.html-->
-    <module name="NewlineAtEndOfFile"/>
-    <!-- See http://checkstyle.sourceforge.net/config_sizes.html -->
-    <module name="FileLength"/>
-    <!-- See http://checkstyle.sourceforge.net/config_whitespace.html -->
-    <module name="FileTabCharacter"/>
-
-    <module name="RegexpMultiline">
-        <property name="format" value="/\*\*\W+\* +\p{javaLowerCase}"/>
-        <property name="fileExtensions" value="java"/>
-        <property name="message"
-                  value="First sentence in a comment should start with a capital letter"/>
-    </module>
-
-    <!-- Trailing spaces -->
-    <!--<module name="RegexpSingleline">-->
-        <!--<property name="format" value="\s+$"/>-->
-        <!--<property name="message" value="Line has trailing spaces."/>-->
-    <!--</module>-->
-
-    <!-- This doesn't work correctly -->
-    <!--Space after 'for' and 'if' -->
-    <!--<module name="RegexpSingleline">-->
-    <!--<property name="format" value="^\s*(for|if)[^ ]"/>-->
-    <!--<property name="message" value="Space needed before opening parenthesis."/>-->
-    <!--</module>-->
-
-    <!-- For each spacing -->
-    <module name="RegexpSingleline">
-        <property name="format" value="^\s*for \(.*?([^ ]:|:[^ ])"/>
-        <property name="message" value="Space needed around ':' character."/>
-    </module>
-
-    <module name="TreeWalker">
-
-        <module name="FileContentsHolder"/>
-
-        <!-- Checks for Javadoc comments.                     -->
-        <!-- See http://checkstyle.sourceforge.net/config_javadoc.html -->
-        <!-- TODO Enable Javadoc on every new project -->
-        <!--<module name="JavadocMethod"/>-->
-        <!--<module name="JavadocType"/>-->
-        <!--<module name="JavadocVariable"/>-->
-        <module name="JavadocStyle"/>
-
-
-        <!-- Checks for Naming Conventions.                  -->
-        <!-- See http://checkstyle.sourceforge.net/config_naming.html -->
-        <module name="MethodName"/>
-        <module name="PackageName"/>
-        <module name="ParameterName"/>
-        <module name="TypeName"/>
-        <module name="ConstantName"/>
-        <module name="LocalFinalVariableName"/>
-        <module name="LocalVariableName"/>
-        <module name="MemberName">
-            <property name="format" value="^(?!m[A-Z][a-zA-Z0-9]*)([a-z][a-zA-Z0-9]*)$"/>
-            <message key="name.invalidPattern" value="Member ''{0}'' should be named with CamelCase and without prefixes."/>
-        </module>
-        <module name="StaticVariableName"/>
-
-        <!-- Checks for imports                              -->
-        <!-- See http://checkstyle.sourceforge.net/config_imports.html -->
-        <module name="AvoidStarImport">
-            <property name="severity" value="warning"/>
-        </module>
-        <module name="IllegalImport"/>
-        <!-- defaults to sun.* packages -->
-        <module name="RedundantImport"/>
-        <module name="UnusedImports">
-            <property name="processJavadoc" value="true"/>
-        </module>
-
-        <!-- Checks for Size Violations.                    -->
-        <!-- See http://checkstyle.sourceforge.net/config_sizes.html -->
-        <module name="LineLength">
-            <property name="max" value="100"/>
-            <property name="ignorePattern"
-                      value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
-        </module>
-        <module name="MethodLength">
-            <property name="max" value="300"/>
-        </module>
-        <module name="ParameterNumber">
-            <property name="max" value="10"/>
-            <property name="ignoreOverriddenMethods" value="true"/>
-            <property name="tokens" value="METHOD_DEF"/>
-        </module>
-
-
-        <!-- Checks for whitespace                               -->
-        <!-- See http://checkstyle.sourceforge.net/config_whitespace.html -->
-        <module name="GenericWhitespace"/>
-        <module name="EmptyForIteratorPad"/>
-        <module name="MethodParamPad"/>
-        <module name="NoWhitespaceAfter">
-            <property name="allowLineBreaks" value="true"/>
-            <property name="tokens"
-                      value="BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS, UNARY_PLUS"/>
-        </module>
-        <module name="NoWhitespaceBefore"/>
-        <module name="OperatorWrap"/>
-        <module name="ParenPad"/>
-        <module name="TypecastParenPad"/>
-        <module name="WhitespaceAfter"/>
-        <module name="WhitespaceAround"/>
-        <module name="AbbreviationAsWordInName">
-            <property name="ignoreFinal" value="false"/>
-            <property name="allowedAbbreviationLength" value="1"/>
-        </module>
-
-        <!-- Modifier Checks                                    -->
-        <!-- See http://checkstyle.sourceforge.net/config_modifier.html -->
-        <module name="ModifierOrder"/>
-        <module name="RedundantModifier"/>
-        <module name="EmptyLineSeparator">
-            <property name="allowNoEmptyLineBetweenFields" value="true"/>
-        </module>
-
-        <!-- Checks for blocks. You know, those {}'s         -->
-        <!-- See http://checkstyle.sourceforge.net/config_blocks.html -->
-        <module name="AvoidNestedBlocks">
-            <property name="allowInSwitchCase" value="true"/>
-        </module>
-        <module name="LeftCurly"/>
-        <!-- Good to have, but equals/hashcode is generated without braces by default in IDE -->
-        <!--<module name="NeedBraces"/>-->
-        <module name="RightCurly"/>
-
-        <!-- Checks for common coding problems               -->
-        <!-- See http://checkstyle.sourceforge.net/config_coding.html -->
-        <!-- Would be nice to have this check, but Parcelable plugin breaks the order -->
-        <!--<module name="DeclarationOrder"/>-->
-        <module name="DefaultComesLast"/>
-        <module name="CovariantEquals"/>
-        <module name="EmptyStatement"/>
-        <module name="EqualsAvoidNull"/>
-        <module name="EqualsHashCode"/>
-        <module name="IllegalInstantiation"/>
-        <module name="MagicNumber">
-            <property name="ignoreHashCodeMethod" value="true"/>
-            <property name="ignoreFieldDeclaration" value="true"/>
-            <property name="ignoreAnnotation" value="true"/>
-            <property name="constantWaiverParentToken"
-                      value="ASSIGN, ARRAY_INIT, EXPR, UNARY_PLUS, UNARY_MINUS,TYPECAST, ELIST, LITERAL_NEW, METHOD_CALL, STAR, DIV, PLUS, MINUS"/>
-        </module>
-        <module name="MissingSwitchDefault">
-            <property name="severity" value="warning"/>
-        </module>
-        <module name="ModifiedControlVariable"/>
-        <!-- Would be nice to have it, but sometimes is needed to have string literals
-        (e.g. in logs)-->
-        <!--<module name="MultipleStringLiterals"/>-->
-        <module name="MultipleVariableDeclarations"/>
-        <module name="OneStatementPerLine"/>
-        <module name="OverloadMethodsDeclarationOrder"/>
-        <module name="PackageDeclaration"/>
-        <module name="RequireThis"/>
-        <module name="SimplifyBooleanExpression"/>
-        <module name="SimplifyBooleanReturn"/>
-        <module name="StringLiteralEquality"/>
-
-        <!-- Checks for class design                         -->
-        <!-- See http://checkstyle.sourceforge.net/config_design.html -->
-        <module name="FinalClass"/>
-        <module name="HideUtilityClassConstructor"/>
-        <!-- Implements Joshua Bloch, Effective Java, Item 17 - Use Interfaces only to define types. -->
-        <module name="InterfaceIsType"/>
-
-        <!-- Miscellaneous other checks.                   -->
-        <!-- See http://checkstyle.sourceforge.net/config_misc.html -->
-        <module name="ArrayTypeStyle"/>
-        <module name="CommentsIndentation"/>
-        <module name="TodoComment">
-            <property name="format" value="(TODO)|(FIXME)"/>
-            <property name="severity" value="warning"/>
-        </module>
-        <module name="UpperEll"/>
-    </module>
-</module>
diff --git a/app/config/pmd/pmd-ruleset.xml b/app/config/pmd/pmd-ruleset.xml
deleted file mode 100755
index 1647c89..0000000
--- a/app/config/pmd/pmd-ruleset.xml
+++ /dev/null
@@ -1,68 +0,0 @@
-<?xml version="1.0"?>
-<ruleset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" name="Android Application Rules"
-         xmlns="http://pmd.sf.net/ruleset/1.0.0"
-         xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd"
-         xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd">
-
-    <description>Custom ruleset for Android application</description>
-
-    <exclude-pattern>.*/R.java</exclude-pattern>
-    <exclude-pattern>.*/gen/.*</exclude-pattern>
-
-    <rule ref="rulesets/java/android.xml"/>
-    <rule ref="rulesets/java/clone.xml" />
-    <rule ref="rulesets/java/finalizers.xml" />
-    <rule ref="rulesets/java/imports.xml" />
-    <rule ref="rulesets/java/logging-java.xml" />
-    <rule ref="rulesets/java/braces.xml" />
-    <rule ref="rulesets/java/strings.xml" />
-    <rule ref="rulesets/java/basic.xml" />
-    <rule ref="rulesets/java/naming.xml"/>
-    <rule ref="rulesets/java/design.xml"/>
-    <rule ref="rulesets/java/unusedcode.xml"/>
-    <rule ref="rulesets/java/codesize.xml"/>
-    <rule ref="rulesets/java/codesize.xml/CyclomaticComplexity">
-        <properties>
-            <property name="reportLevel" value="1"/>
-        </properties>
-    </rule>
-    <rule ref="rulesets/java/codesize.xml/ExcessiveMethodLength">
-        <properties>
-            <property name="minimum" value="20"/>
-        </properties>
-    </rule>
-    <rule ref="rulesets/java/codesize.xml/ExcessiveParameterList">
-        <properties>
-            <property name="minimum" value="1"/>
-        </properties>
-    </rule>
-    <rule ref="rulesets/java/codesize.xml/ExcessiveClassLength">
-        <properties>
-            <property name="minimum" value="200"/>
-        </properties>
-    </rule>
-    <rule ref="rulesets/java/codesize.xml/NPathComplexity">
-        <properties>
-            <property name="minimum" value="5"/>
-        </properties>
-    </rule>
-    <rule ref="rulesets/java/codesize.xml/NcssMethodCount">
-        <properties>
-            <property name="minimum" value="20"/>
-        </properties>
-    </rule>
-    <rule ref="rulesets/java/codesize.xml/TooManyMethods">
-        <properties>
-            <property name="maxmethods" value="10"/>
-        </properties>
-    </rule>
-    <rule ref="rulesets/java/comments.xml">
-        <exclude name="CommentRequired"/>
-    </rule>
-    <rule ref="rulesets/java/comments.xml/CommentSize">
-        <properties>
-            <property name="maxLineLength" value="160" />
-            <property name="maxLines" value="12" />
-        </properties>
-    </rule>
-</ruleset>
\ No newline at end of file
diff --git a/app/config/quality.gradle b/app/config/quality.gradle
index 3f615c6..5292371 100644
--- a/app/config/quality.gradle
+++ b/app/config/quality.gradle
@@ -1,6 +1,4 @@
-apply plugin: 'pmd'
 apply plugin: 'build-dashboard'
-apply from: 'config/checkstyle/checkstyle.gradle'
 
 android {
     lintOptions {
@@ -13,38 +11,4 @@ android {
     }
 }
 
-task pmd(type: Pmd) {
-    description 'Run PMD/CPD analysis.'
-    group 'verification'
-
-    ignoreFailures = true
-    ruleSetFiles = files("${project.rootDir}/app/config/pmd/pmd-ruleset.xml")
-    ruleSets = []
-
-    source = fileTree('src/main/java')
-    include '**/*.java'
-    exclude '**/gen/**'
-
-    reports {
-        xml.enabled = true
-        html.enabled = true
-        xml {
-            destination "$project.buildDir/reports/pmd/pmd.xml"
-        }
-        html {
-            destination "$project.buildDir/reports/pmd/pmd.html"
-        }
-    }
-
-    doLast {
-        File outDir = new File("$project.buildDir/reports/pmd/")
-        ant.taskdef(name: 'cpd', classname: 'net.sourceforge.pmd.cpd.CPDTask',
-                classpath: configurations.pmd.asPath)
-        ant.cpd(minimumTokenCount: '50', format: 'xml',
-                outputFile: new File(outDir, 'cpd.xml')) {
-            fileset(dir: "src/main/java") {
-                include(name: '**/*.java')
-            }
-        }
-    }
-}
+// TODO: configure detekt
\ No newline at end of file