Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial scale kept for first minute of experiment #261

Closed
wants to merge 3 commits into from

Conversation

Lightxyz
Copy link
Contributor

Summary

The initial scale set by the profiling should be kept until the start of the warmup phase.

Implementation Notes ⚒️

  • For the first minute, there is a minimum scale equal to the initial scale determined by the profiling phase. After that minute, we update the revisions to set the initial and minimum scale to 0.

External Dependencies 🍀

  • N/A

Breaking API Changes ⚠️

  • N/A

Simply specify none (N/A) if not applicable.

For the first minute, there is a minimum scale equal to the initial scale determined by the profiling phase. After that minute, we update the revisions to set the initial and minimum scale to 0.

Signed-off-by: Lightxyz <[email protected]>
@Lightxyz Lightxyz linked an issue Sep 10, 2023 that may be closed by this pull request
@Lightxyz Lightxyz self-assigned this Sep 10, 2023
@Lightxyz Lightxyz added the bug Something isn't working label Sep 10, 2023
@Lightxyz Lightxyz closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warmup initial scale doesn't work as intended
1 participant