Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warmup period might be set incorrectly #229

Open
leokondrashov opened this issue Jul 5, 2023 · 0 comments
Open

Warmup period might be set incorrectly #229

leokondrashov opened this issue Jul 5, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@leokondrashov
Copy link
Contributor

Currently, warmup period is only set in configuration, with no validation on whether this amount of time for warmup is enough. This creates a situation when the resulting measurements are useless due to warmup taking longer than it was set in the configuration.

There is a proposal of a solution: add a runtime check for the end of warmup period whether the cluster has stabilized. If it's not, we should finish execution and notify the user about the fact that set warmup period is too small for current setup to stabilize under current load. Also, it should be passed to experiment driver used for load sweeps through different traces, since failed to warmup for smaller trace means that the same will happen for a bigger load.

@leokondrashov leokondrashov added the good first issue Good for newcomers label Jul 5, 2023
@leokondrashov leokondrashov changed the title Warmup period Warmup period might be set incorrectly Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant