-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace remaining calls to DPIUtil::get(Native)DeviceZoom() #79
Replace remaining calls to DPIUtil::get(Native)DeviceZoom() #79
Comments
@amartya4256 did you cover all places of that or are some still missing? |
Still working on it. |
Here we need to think about how we are gonna replace these calls from the places where the objects are initialized. One alternative could be using the primary monitor zoom from the device but it might have some issue with threads. |
Does anyone know if there is a actually PR for this issue? If yes, please link it here. The state "In Review" means that there is a PR, but it seems to me that this issue needs further discussion and should be moved to "New" until a decision on how to proceed has been made. WDYT @akoch-yatta / @HeikoKlare ? |
eclipse-platform/eclipse.platform.swt#1401 is related to a different issue as it is supposed to replace the zoom value "correction" for non-image contexts and not to replace static usage of (native)DeviceZoom from DPIUtil, isn't it, @akoch-yatta? |
Next step: document and investigate usages of these methods |
@akoch-yatta , @amartya4256 did eclipse-platform/eclipse.platform.swt#1369 solve this issue or do we expect another PR to be necessary? |
|
Yes, we discussed it yesterday |
To get rid of the static device zoom in DPIUtil, we should get rid of all remaining calls to:
Important: problematic is that Display::getDeviceZoom() calls getPrimaryMonitor() that will throw an exception when called from another thread
The text was updated successfully, but these errors were encountered: