Fix python formatting everywhere #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to build
|
Overall readability score: 54.45 (🟢 +0)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
npentrel
force-pushed
the
test-flake8
branch
from
79d6835 to
3484bd9
Compare
andf-viam
approved these changes
Sep 19, 2023
| @@ -448,10 +448,11 @@ Get an [`DigitalInterrupt`](#digital_interrupts) by `name.` | |||
| For more information, see the [Python SDK Docs](https://python.viam.dev/autoapi/viam/components/board/index.html#viam.components.board.Board.digital_interrupt_by_name). | |||
|
|
|||
| ```python | |||
| my_board = Board.from_robot(robot=robot, name=) | |||
| my_board = Board.from_robot(robot=robot, name="my_board") | |||
There was a problem hiding this comment.
Nice catch! No way flake8 caught this one???
There was a problem hiding this comment.
it did tell me there was an error - I did manually have to fix it though
| @@ -133,7 +133,7 @@ frame = await my_cam.get_image() | |||
|
|
|||
| # Convert "frame" to a standard 2D image representation. | |||
| # Remove the 1st 3x8 bytes and reshape the raw bytes to List[List[Int]]. | |||
| standard_frame frame.bytes_to_depth_array() | |||
| standard_frame = frame.bytes_to_depth_array() | |||
There was a problem hiding this comment.
This too! Surely this is naomi8 ??
There was a problem hiding this comment.
flake8 says error - naomi fixes
| await start.set_power(.8) | ||
| await asyncio.sleep(0.1) | ||
| if (await GPIO.get()) == False: | ||
| if not (await GPIO.get()): |
| @@ -294,10 +295,10 @@ Copy this code and add it to your own code within the main function block: | |||
| ```python {class="line-numbers linkable-line-numbers"} | |||
| while True: | |||
| print(party_return_value.get()) | |||
| while (await party_return_value.get()) == True: | |||
| while (await party_return_value.get()): | |||
There was a problem hiding this comment.
the word is pythonic
Co-authored-by: andf-viam <[email protected]>
npentrel
commented
Sep 20, 2023
npentrel
commented
Sep 20, 2023
JessamyT
reviewed
Sep 20, 2023
Co-authored-by: JessamyT <[email protected]>
|
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/6e3895f90a52b7a412659a363e57d2fc243cf83f/public |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.