Address review

Author: hexbabe

components/camera/camera.go

@@ -179,6 +179,11 @@ func GetImageFromGetImages(ctx context.Context, sourceName *string, mimeType str
 		return nil, ImageMetadata{}, errors.New("no images returned from camera")
 	}
 
+	// if mimeType is empty, use JPEG as default
+	if mimeType == "" {
+		mimeType = utils.MimeTypeJPEG
+	}
+
 	var img image.Image
 	if sourceName == nil {
 		img = images[0].Image
@@ -224,8 +229,10 @@ func GetImagesFromGetImage(
 	if len(resBytes) == 0 {
 		return nil, resource.ResponseMetadata{}, errors.New("received empty bytes from camera")
 	}
-	if resMetadata.MimeType != mimeType {
-		logger.Warnf("requested mime type %s, but received %s", mimeType, resMetadata.MimeType)
+
+	resMimetype, _ := utils.CheckLazyMIMEType(resMetadata.MimeType)
+	if resMimetype != mimeType {
+		logger.Warnf("requested mime type %s, but received %s", mimeType, resMimetype)
 	}
 
 	img, err := rimage.DecodeImage(ctx, resBytes, utils.WithLazyMIMEType(mimeType))

components/camera/camera_test.go

@@ -287,7 +287,7 @@ func TestGetImageFromGetImages(t *testing.T) {
 	testImg1 := image.NewRGBA(image.Rect(0, 0, 100, 100))
 	testImg2 := image.NewRGBA(image.Rect(0, 0, 200, 200))
 
-	testCam := inject.NewCamera("test_cam")
+	testCam := inject.NewCamera("rgba_cam")
 	testCam.ImagesFunc = func(ctx context.Context) ([]camera.NamedImage, resource.ResponseMetadata, error) {
 		return []camera.NamedImage{
 			{Image: testImg1, SourceName: source1Name},
@@ -379,7 +379,7 @@ func TestGetImagesFromGetImage(t *testing.T) {
 	logger := logging.NewTestLogger(t)
 	testImg := image.NewRGBA(image.Rect(0, 0, 100, 100))
 
-	testCam := inject.NewCamera("test_cam")
+	testCam := inject.NewCamera("rgba_cam")
 	testCam.ImageFunc = func(ctx context.Context, mimeType string, extra map[string]interface{}) ([]byte, camera.ImageMetadata, error) {
 		imgBytes, err := rimage.EncodeImage(ctx, testImg, mimeType)
 		if err != nil {