Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the color pallete states #74

Open
maheshmnj opened this issue Jan 7, 2024 · 10 comments · May be fixed by #79
Open

Store the color pallete states #74

maheshmnj opened this issue Jan 7, 2024 · 10 comments · May be fixed by #79
Assignees
Labels
enhancement New feature or request

Comments

@maheshmnj
Copy link

maheshmnj commented Jan 7, 2024

Storing the states would allow the undo-redo feature to be able to switch between states and also compare between color palettes. To give you more context. I created a color palette and then hit Random and now I have no way to switch back.

Proposed solution:

  1. The app should show the list of states (ListView), clicking each listItem should switch to that state.
  2. This should also be binded with keyboard shortcuts for undo (ctrl+z) and redo (ctrl+shift+z)
  3. User should have option to clear the entire state (list) or a specific element in the list.
@victoreronmosele
Copy link
Owner

Thanks @maheshmnj. I agree and would like to have this feature in the project.

Can you describe some more how you imagine the flow to be?

@maheshmnj
Copy link
Author

@victoreronmosele I have updated the description. I will see if I can contribute to this feature later this week.

@maheshmnj
Copy link
Author

I implemented this log history today to one of my app https://pastelog.netlify.app/ hopefully it gives you an idea

@victoreronmosele
Copy link
Owner

Thanks!

Your implementation of the state history on https://pastelog.netlify.app/ looks great!

I also like the idea for the keybindings.

I'm currently working on #73 locally and I'll look deeper into this in a few days.

@victoreronmosele
Copy link
Owner

victoreronmosele commented Feb 12, 2024

@maheshmnj, I just merged in a UI update via #75, and I added a toolbar that will contain undo and redo state buttons.

I'll do some work on this and share a preview soon.

I'll also appreciate some feedback on the UI update. See demo here: #75 (comment).

@maheshmnj
Copy link
Author

maheshmnj commented Feb 12, 2024

@victoreronmosele The UI looks great!

I have a few additonal improvements to suggest

  1. Clicking on black app bar reloads the app
  2. There seems some issue with the text rendering
image

@victoreronmosele
Copy link
Owner

@maheshmnj, thanks for the review and suggestions. 🙌🏽

I'll work on fixes for the issues.

@victoreronmosele
Copy link
Owner

Added the fix for the empty space reloading the app.

The text rendering bug isn't so clear to me.

@victoreronmosele victoreronmosele self-assigned this Feb 18, 2024
@victoreronmosele victoreronmosele linked a pull request Feb 19, 2024 that will close this issue
6 tasks
@victoreronmosele
Copy link
Owner

victoreronmosele commented Feb 19, 2024

@maheshmnj here's the current progress (undo and redo):

flutter_gradient_generator_undo_redo.mp4

Preview URL: https://flutter-gradient-generator--pr79-state-history-pnd1e08v.web.app/
PR: #79

Adding the version history next.

@maheshmnj
Copy link
Author

Looks great!

@victoreronmosele victoreronmosele added the enhancement New feature or request label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants