Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to avoid settings.json always apearing as changed file in Version Control tab? #3

Open
joernflath opened this issue Apr 19, 2023 · 3 comments
Assignees

Comments

@joernflath
Copy link

Hello,

we're versioning the Workspace level settings.json file, so we can share settings across our team.
Obviously to change the color of the bar, it will write into the settings.json, but on a Workspace level.

Is there a possibility to have the changes to "workbench.colorCustomizations" written into the User level settings.json?
I have the setting only applied on the User level.

@victorgz
Copy link
Owner

Hi @joernflath, the first version of the extension was working only on User level, however there was an issue which force us to change the color configuration to Workspace level (#1):

  • If you define the color at the User level and you have multiple VSCode windows open with different projects, the same color will be applied to all the windows and this won't reflect the reality, because you can be connected to different orgs in different workspaces.
  • The only solution here was to apply the color on the Workspace level

I'm not sure if the workspace shared settings.json config changes a lot in your project, but I would suggest to always ignore the file except when you want to include new rules (that shouldn't be that often I believe). I know it's a bit tedious task, but it's the only possible way I see for now

@jlawrence124
Copy link

Hey @victorgz,

First thanks so much for your hard work on this extension. This will be a big help to my team and I. Is it possible that this workspace setting can be made configurable? I understand there are some issues with multiple windows, but for a lot of users they only work with one window open anyway. Thoughts on this?

@victorgz
Copy link
Owner

victorgz commented Oct 2, 2023

Hi @jlawrence124, thanks for the feedback and happy to hear that the extension is useful for you and your team !
That could be a good solution indeed, to have a configurable option to decide where to store the settings (user or workspace level). I'll try to have a look at it and let you know 😃

@victorgz victorgz self-assigned this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants