Added Scan features #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| result = | ||
| Items: dataTrans.fromDynamo(data.Items), | ||
| Count: data.Count, | ||
| LastEvaluatedKey: data.LastEvaluatedKey |
There was a problem hiding this comment.
Haven't merged this yet because this signature is not in line with the rest of Dynasty.
I try to abstract the internals of Dynamo from the end user of Dynasty. Hence why all of the other API calls return objects with slightly different names and without capitalizing everything.
Also, this introduces a non-trivial breaking change to Scan. It used to return just an array of objects, now this new object with multiple keys.
Anyway, thanks for the changes! I will do my best to work with them and "Dynasty-ify" them before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution to resolve #61