Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seek bar's aria-valuetext attribute should have times written out in words rather than numerical timestamp format #6335

Open
claudiah12 opened this issue Nov 26, 2019 · 6 comments
Labels
8.x a11y This item might affect the accessibility of the player

Comments

@claudiah12
Copy link
Contributor

Description

The current time & duration in the aria-valuetext property of the seek bar is written as a timestamp, which in most cases screen readers will read as just numbers and punctuation, rather than something understandable as time. The time should written out in plain text like "x minutes, y seconds" for the aria value.

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. Turn on screen reader software
  2. Navigate to the seek bar of a video
  3. The screen reader will read the timestamp string as numbers and punctuation rather than an understandable time

Results

Expected

If seek bar is at 00:20/14:05, then screen reader announces 'twenty seconds of 14 minutes, 5 seconds

Actual

If seek bar is at 00:20/14:05, then screen reader announces 'Zero colon zero colon twenty of fourteen colon one'.

@welcome
Copy link

welcome bot commented Nov 26, 2019

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@stale
Copy link

stale bot commented Jan 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Jan 25, 2020
@stale stale bot closed this as completed Feb 2, 2020
@gkatsev gkatsev reopened this Apr 1, 2020
@stale stale bot removed the outdated Things closed automatically by stalebot label Apr 1, 2020
@gkatsev gkatsev added a11y This item might affect the accessibility of the player outdated Things closed automatically by stalebot labels Apr 1, 2020
@stale stale bot removed the outdated Things closed automatically by stalebot label Apr 1, 2020
OwenEdwards added a commit to OwenEdwards/video.js that referenced this issue Apr 18, 2020
@OwenEdwards
Copy link
Member

OwenEdwards commented Apr 18, 2020

@claudiah12 unfortunately, implementing a change like this is going to be very complicated to do correctly, because of the complexity of internationalizing/localizing plurals (see, for example, https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_and_Plurals). So "1 minute", "2 minutes", etc.

You can look at https://github.com/OwenEdwards/video.js/tree/fix/improve-aria-text-of-progress-bar-for-screen-reader-users for a basic implementation in English, but even that doesn't handle plurals correctly.

@gkatsev
Copy link
Member

gkatsev commented Apr 21, 2020

I hadn't even considered how difficult it could be to do.

@gkatsev
Copy link
Member

gkatsev commented Jun 30, 2021

With Video.js 8, we're going to be dropping support for IE11, this means that Intl.PluralRules will be available in all the browsers we support, which should hopefully allow us to do a better job and do it more easily.

@damanV5
Copy link

damanV5 commented Feb 23, 2025

#8985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.x a11y This item might affect the accessibility of the player
Projects
None yet
Development

No branches or pull requests

4 participants