Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in example code #27

Open
nblei opened this issue Jan 12, 2021 · 0 comments
Open

Bugs in example code #27

nblei opened this issue Jan 12, 2021 · 0 comments

Comments

@nblei
Copy link

nblei commented Jan 12, 2021

A number of bugs exist in the sample code which cause runtime errors (segfault on my system).

The first is that CBFormat myFormat must be configured. I used myBFormat.Configure(1, true, 512).

Next is an error in the comments. The ambisonic encoder is also 1st order, not third order.

The second error is in the the configuration of CAmbisonicDecoder myDecoder.
myDecoder.Configure(1, true, kAmblib_50, 5) is missing an argument for nBlockSize. The function signature is:
bool Configure(unsigned int nOrder, bool b3D, unsigned int nBlockSize, int nSpeakerSetUp, unsigned int nSpeakers = 0).

I would also recommend changing enumerated types into enum classes, providing type safety, rather than using ints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant