Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API break with commit [Fixed a bug that caused an allocation error] #38

Open
kwizart opened this issue Mar 3, 2023 · 0 comments
Open

Comments

@kwizart
Copy link

kwizart commented Mar 3, 2023

          [Fixed a bug that caused an allocation error](https://github.com/videolabs/libspatialaudio/pull/24/commits/10e70839a9ad019e455c48c9d2bf93016ba37633)

This commit breaks API with vlc-3.x
Is there a way to avoid the API break ?

audio_filter/channel_mixer/spatialaudio.cpp: In function 'int Open(vlc_object_t*)':
audio_filter/channel_mixer/spatialaudio.cpp:512:33: error: no matching function for call to 'CAmbisonicZoomer::Configure(unsigned int&, bool, int)'
  512 |     if (!p_sys->zoomer.Configure(p_sys->i_order, true, 0))
      |          ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/spatialaudio/AmbisonicProcessor.h:22,
                 from /usr/include/spatialaudio/Ambisonics.h:28,
                 from audio_filter/channel_mixer/spatialaudio.cpp:43:
/usr/include/spatialaudio/AmbisonicZoomer.h:40:18: note: candidate: 'virtual bool CAmbisonicZoomer::Configure(unsigned int, bool, unsigned int, unsigned int)'
   40 |     virtual bool Configure(unsigned nOrder, bool b3D, unsigned nBlockSize, unsigned nMisc);
      |                  ^~~~~~~~~
/usr/include/spatialaudio/AmbisonicZoomer.h:40:18: note:   candidate expects 4 arguments, 3 provided
make[4]: *** [Makefile:26640: audio_filter/channel_mixer/libspatialaudio_plugin_la-spatialaudio.lo] Error 1

Originally posted by @kwizart in #24 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant