Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obfuscation potentially mutates req/res data #44

Open
xdissent opened this issue May 18, 2017 · 1 comment · May be fixed by #54
Open

Obfuscation potentially mutates req/res data #44

xdissent opened this issue May 18, 2017 · 1 comment · May be fixed by #54

Comments

@xdissent
Copy link

If you add an obfuscate option like obfuscate: ['body.password'] and attempt to access req.body.password after the req has been logged (immediate: true for example), you'll receive [HIDDEN] as the value for req.body.password. The logger should deep copy the req/res data (body, headers), rather than assigning, to prevent mutation.

@jingram-classy
Copy link

jingram-classy commented Oct 24, 2017

We provided an optimization to do work after express returned and turns out our sensitive but important information is clobbered by [HIDDEN] string.

@woodpig07 woodpig07 linked a pull request Sep 17, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants