Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation errors with nodejs v12 #55

Open
bdurrani opened this issue Apr 30, 2019 · 8 comments
Open

deprecation errors with nodejs v12 #55

bdurrani opened this issue Apr 30, 2019 · 8 comments

Comments

@bdurrani
Copy link

This library will generate deprecation warnings with node v12.

(node:8) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
    at ServerResponse.logging (/app/node_modules/express-bunyan-logger/index.js:130:36)
    at ServerResponse.emit (events.js:201:15)
    at ServerResponse.EventEmitter.emit (domain.js:471:20)

The fix is fairly straightforward.
I can create a PR for it if one is required.

@oliversalzburg
Copy link
Contributor

It doesn't look like PRs have been merged in a while :( I'd still love to see one so I can cherry-pick the change into our fork :D

@uvios
Copy link

uvios commented Sep 20, 2019

I am getting same warning.

@twhitner-vistaprint
Copy link

Any movement on this? Very quick fix to get rid of the ERROR.

@twhitner-vistaprint
Copy link

I added a PR to address this. Anyway to get it merged and released?

@mrYakamoto
Copy link

Any chance we can get this merged?

@oliversalzburg
Copy link
Contributor

You can try emailing the author, but I doubt anything will happen on GitHub. You can also just fork the project or reimplement the logger in your own code. Good luck :)

@chaudhryjunaid
Copy link

I have forked and patched express-bunyan-logger at: https://github.com/chaudhryjunaid/express-bunyan-logger
PR: chaudhryjunaid#1

Kindly install using:

npm i 'git+https://github.com/chaudhryjunaid/express-bunyan-logger.git'

and use like this:

app.use(require('@chaudhryjunaid/express-bunyan-logger')(loggerOptions));

@chaudhryjunaid
Copy link

I have published an npm package at: https://www.npmjs.com/package/@chaudhryjunaid/express-bunyan-logger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants