Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make catchall bucket optional #76

Open
Dieterbe opened this issue Dec 18, 2013 · 3 comments
Open

make catchall bucket optional #76

Dieterbe opened this issue Dec 18, 2013 · 3 comments

Comments

@Dieterbe
Copy link
Contributor

it should be possible to choose whether you want a catchall bucket or not.
i think this makes sense for both aggregation and grouping.
a simple syntax and implementation could be like so:

# no catchall
>>> 'us-east|us-west'.split('|')
['us-east', 'us-west']
# with catchall
>>> 'us-east|us-west|'.split('|')
['us-east', 'us-west', '']
@Dieterbe
Copy link
Contributor Author

thinking more about it, here's how i think aggregation and grouping should work:

  • avg by & sum by:
    • no bucket specified -> aggregate all different values together
    • buckets -> aggregate only together what goes into same bucket (add catchall bucket if you want it)
    • catchall bucket -> aggregate different values together
    • -> no bucket specified defaults to a catchall bucket
  • group by:
    • no bucket specified -> 1 group graph per every different value
    • buckets -> group what goes into same bucket onto 1 graph (add catchall bucket if you want it)
    • catchall bucket -> group different values on 1 graph.
    • -> no bucket specified defaults to no bucket

@Dieterbe
Copy link
Contributor Author

until now, group by without explicit buckets defaults to catchall bucket and then uses that to make a graph per every different value which means we don't have a way to have a few buckets and a graph for all remaining items.

@Dieterbe
Copy link
Contributor Author

here's some work in progress towards this https://github.com/vimeo/graph-explorer/tree/rethink-buckets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant