Fix

Author: danog

src/Psalm/Internal/Analyzer/StatementsAnalyzer.php

@@ -39,7 +39,6 @@
 use Psalm\Internal\Analyzer\Statements\UnsetAnalyzer;
 use Psalm\Internal\Analyzer\Statements\UnusedAssignmentRemover;
 use Psalm\Internal\Codebase\DataFlowGraph;
-use Psalm\Internal\Codebase\TaintFlowGraph;
 use Psalm\Internal\Codebase\VariableUseGraph;
 use Psalm\Internal\DataFlow\DataFlowNode;
 use Psalm\Internal\FileManipulation\FileManipulationBuffer;
@@ -150,8 +149,11 @@ final class StatementsAnalyzer extends SourceAnalyzer
      */
     public array $foreach_var_locations = [];
 
-    public function __construct(protected SourceAnalyzer $source, public NodeDataProvider $node_data, private readonly bool $root_scope)
-    {
+    public function __construct(
+        protected SourceAnalyzer $source,
+        public NodeDataProvider $node_data,
+        private readonly bool $root_scope,
+    ) {
         $this->file_analyzer = $source->getFileAnalyzer();
         $this->codebase = $source->getCodebase();
 

src/Psalm/Internal/Codebase/TaintFlowGraph.php

@@ -225,7 +225,7 @@ public function connectSinksAndSources(Progress $progress): void
         $codebase = $project_analyzer->getCodebase();
 
         // Remove all specializations without an outgoing edge
-        /*foreach ($this->specializations as $k => &$map) {
+        foreach ($this->specializations as $k => &$map) {
             foreach ($map as $kk => $specialized_id) {
                 if (!isset($this->forward_edges[$specialized_id])) {
                     unset($map[$kk]);
@@ -234,7 +234,7 @@ public function connectSinksAndSources(Progress $progress): void
             if (!$map) {
                 unset($this->specializations[$k]);
             }
-        } unset($map);*/
+        } unset($map);
 
         $stack = [];
         // reprocess resolved descendants up to a maximum nesting level of 40
@@ -270,7 +270,9 @@ public function connectSinksAndSources(Progress $progress): void
                 // If this is a specialized node, de-specialize;
                 // Then, if we have one or more edges starting at the de-specialized node,
                 // process destinations of those edges.
-                if ($source->specialization_key !== null && isset($this->specialized_calls[$source->specialization_key])) {
+                if ($source->specialization_key !== null
+                    && isset($this->specialized_calls[$source->specialization_key])
+                ) {
                     /** @var string $source->unspecialized_id */
                     if (!isset($this->forward_edges[$source->unspecialized_id])) {
                         continue;
@@ -310,9 +312,6 @@ public function connectSinksAndSources(Progress $progress): void
                     if ($specialized_calls) {
                         // If processing descendants of a specialized call, accept only descendants.
                         foreach ($this->specializations[$source->id] as $specialization => $specialized_id) {
-                            if (!isset($this->forward_edges[$specialized_id])) {
-                                continue;
-                            }
                             if (!isset($specialized_calls[$specialization])) {
                                 continue;
                             }
@@ -345,9 +344,6 @@ public function connectSinksAndSources(Progress $progress): void
                     } else {
                         // If not processing descendants, accept all specializations.
                         foreach ($this->specializations[$source->id] as $specialization => $specialized_id) {
-                            if (!isset($this->forward_edges[$specialized_id])) {
-                                continue;
-                            }
                             $new_source = new DataFlowNode(
                                 $specialized_id,
                                 $source->id,