Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Compose MaterialTheme #194

Open
DatL4g opened this issue Sep 7, 2022 · 1 comment
Open

Apply Compose MaterialTheme #194

DatL4g opened this issue Sep 7, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest mentoring The maintainer of this library is available for mentoring on this issue

Comments

@DatL4g
Copy link

DatL4g commented Sep 7, 2022

When using compose on desktop it's common to use MaterialTheme.

This theme provides several colors:

  • primary
  • primaryVariant
  • secondary
  • secondaryVariant
  • background
  • surface
  • error
  • onPrimary
  • onSecondary
  • onBackground
  • onSurface
  • onError

The colors are providing r, g, b values so it's easy to create ColorUIResource off of them.

How do we (need to) map them to the (LAF) MaterialTheme colors?

For example compose button uses primaryVariant as background color and onPrimary as text color for this button.
And we want to have the same appearance in JComponents, plus hopefully not setting each component on it's one.

@vincenzopalazzo
Copy link
Owner

MaterialTheme is older than others proposal and I would be more that happy to see some PR to refactor the name and make it inside the Material-UI-Swing too.

Pr are welcome :) and also if you want help I can mentor your on it

@vincenzopalazzo vincenzopalazzo added enhancement New feature or request good first issue Good for newcomers mentoring The maintainer of this library is available for mentoring on this issue labels Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest mentoring The maintainer of this library is available for mentoring on this issue
Projects
None yet
Development

No branches or pull requests

2 participants