Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain cycle on TRMosaicLayoutDelegate #21

Open
Drusy opened this issue Apr 13, 2018 · 0 comments
Open

Retain cycle on TRMosaicLayoutDelegate #21

Drusy opened this issue Apr 13, 2018 · 0 comments

Comments

@Drusy
Copy link
Contributor

Drusy commented Apr 13, 2018

The following delegate should be weak: open var delegate: TRMosaicLayoutDelegate!
Being a strong reference lead to a retain cycle on any controller using this delegate.

I will propose a PR soon to fix this if you don't mind.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Drusy