Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't subscribe item after setting up subscription #62

Open
hardreggaecafe opened this issue Aug 12, 2019 · 11 comments
Open

Can't subscribe item after setting up subscription #62

hardreggaecafe opened this issue Aug 12, 2019 · 11 comments
Assignees

Comments

@hardreggaecafe
Copy link

I just set up spree_product_subscriptions on spree 3.7.2 along with installation procedure.
Here's my env.

I reviewed steps of github like this.

  • Add spree_product_subscriptions to your Gemfile:

    gem 'spree_product_subscriptions', github: 'vinsol-spree-contrib/spree_product_subscriptions'

  • Bundle your dependencies and run the installation generator:

    bundle
    bundle exec rails g spree_product_subscriptions:install

  • You can also seed the default data with:

  • bundle exec rails g spree_product_subscriptions:seed

After installation, started my app. And then configured the item like this.
AwesomeScreenshot-localhost-admin-products-ruby-on-rails-bag-edit-2019-08-08_6_45 (1)

Here's product page.
AwesomeScreenshot-localhost-products-ruby-on-rails-bag-2019-08-08_6_38 (1)

What happened? Tell me how to fix.

@pratibhamansinghka
Copy link

Hi @hardreggaecafe
Can you provide some example repository where I can replicate your issue?

@hardreggaecafe
Copy link
Author

Hi, @pratibhamansinghka
Here's the one.
https://github.com/hardreggaecafe/sample_spree_subscription/tree/master
And data is like this.
spree-sample.sql.zip

I appreciate your sincerity.

@hardreggaecafe
Copy link
Author

@pratibhamansinghka How's it going? If you can't reproduce that issue, I'll help you. Name it.

@hardreggaecafe
Copy link
Author

@pratibhamansinghka Did you reproduce it?

@pratibhamansinghka
Copy link

Hi @hardreggaecafe
We have reproduce the issue.
Currently this extension is working fine with versions upto spree 3.5
In version 3.6 and 3.7 there are major changes in the API.
We will be working on upgrade to make it compatible with latest versions.

You can also raise a PR for the same and we will be happy to merge that.

@hardreggaecafe
Copy link
Author

@pratibhamansinghka
Thanks for the answer.
So what should I push for PR?

@hardreggaecafe
Copy link
Author

@pratibhamansinghka Excuse me. Could you tell me what should I do for PR? Name it, please.

@hardreggaecafe
Copy link
Author

@pratibhamansinghka Could you tell me what's going on?

@vinay-mittal
Copy link
Member

@hardreggaecafe You can upgrade this gem to be compatible with spree versions 3.6 and 3.7. We are working on the upgrades. Meanwhile, if you have already fixed the issues in upgrades, you can raise a pull request against appraise branch and we will review and merge it.

@hardreggaecafe
Copy link
Author

Thank you for the reply @vinay-mittal . Unfortunately, I can't figure out how to fix this problem.
If you tell me where to check on source code, I'll check on it.

@jessehanley
Copy link

Hey @vinay-mittal and @pratibhamansinghka, any updates here on the upgrade?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants