Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Channel model for implementing webhooks properly #1

Open
virajvchavan opened this issue Mar 17, 2020 · 0 comments
Open

Create a Channel model for implementing webhooks properly #1

virajvchavan opened this issue Mar 17, 2020 · 0 comments
Assignees
@virajvchavan
Labels
enhancement New feature or request priority

Comments

@virajvchavan
Copy link
Owner

Currently there is no abstraction over Google Calendar API's registered webhooks (Notification channels).

We are relying on custom tokens sent on each webhook registration to identify which resources to update. Along with that we're storing sync_tokens for resources in their respective models.

Currently there is no way to cancel a webhook because we are not persisting its channel_id. Which means even if we delete a resource from our system, we'll keep getting callback requests for those resources.

A new model called 'NotificationChannel' can provide a simple interface for dealing with this. A NotificationChannel can belong to any resource that is being watched. This will also eliminate the need to store sync_tokens in respective models.
@virajvchavan virajvchavan added the enhancement New feature or request label Mar 17, 2020
@virajvchavan virajvchavan self-assigned this Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@virajvchavan virajvchavan

Labels
enhancement New feature or request priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@virajvchavan