-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate changes/fixes to original repository of bigtext.js #2
Comments
Hi, |
@1010lex thanks for the feedback. maybe you can send a PR to the original repo with this fixes and additions if they are merged we are happy, if not, we ll stay with our fork |
@timomayer I think when addressing this it should be adressed in multiple PRs with minimal footprint of the changes. So the original maintainer can get reflect those changes easily. In addition in the origin repository exist already PRs which seem to address the same bug we had to workaround - those are unanswered and unmerged. As I'm currently short on time to prepare a good PR - plus those open PRs exist already - I wouldn't take action for now. Note: Despite splitting our changes in multiple PR is reasonable it wouldn't help us if not every one gets merged. |
Nevermind - by writing this comment I got unassigned.
|
Hi Alex,
It seems bigtext.js to have active support on github as they immediately fixed the jquery3 compatibility issue that I reported. I recommend you open issues and/or pull requests in original repository for changes you have made here (considering that these changes are improvements and bug fixes rather than customization of original library), so we can retire this fork and use the original repository instead. This also ensures changes/fixes we make are peer reviewed by their developers and that we don't need to maintain two repositories in sync.
The text was updated successfully, but these errors were encountered: