Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CEF: Modeling of subequipment causes wrong summary of mass and power #206

Open
dellerDLR opened this issue Dec 7, 2023 · 2 comments · May be fixed by #218
Open

CEF: Modeling of subequipment causes wrong summary of mass and power #206

dellerDLR opened this issue Dec 7, 2023 · 2 comments · May be fixed by #218
Assignees
@DimitriDiantos
Labels
bug Something isn't working

Comments

@dellerDLR
Copy link
Contributor

Describe the bug
The calculation of mass and power is wrong is subequipments are used.

To Reproduce
Steps to reproduce the behavior:

  1. Model a system with subequipments and also add mass and powerparameters to the main equipment
  2. Set power and mass for the main equipment to 0
  3. Check the mass and power parameters on sub- and systemlevel

Expected behavior
It should be possible to also model subequipments to group equipments

Screenshots
Check the teamserver for a demo model. Message me for further information for the access.

Desktop (please complete the following information):

  • OS: Windows 10
  • Version 22H2
@dellerDLR dellerDLR added the bug Something isn't working label Dec 7, 2023
@dellerDLR
Copy link
Contributor Author

After discussion with @franzTobiasDLR a potential fix might be to change the equations

Ref: massTotal = ( massPerUnit + summary {
	EquipmentMassParameters.massTotal , 1
}

The 1 has to be changed, sothat the mass/power is not counted twice.

@dellerDLR dellerDLR changed the title CEF: Modeling of subequipment causes wrong CEF: Modeling of subequipment causes wrong summary of mass and power Dec 7, 2023
@dellerDLR
Copy link
Contributor Author

Bump, still relevant

DimitriDiantos pushed a commit that referenced this issue Mar 6, 2024
Task #206 fix the bug in the equation where mass and power are being
0902adc 
counted twice.
@DimitriDiantos DimitriDiantos linked a pull request Mar 6, 2024 that will close this issue
Task #206 fix the bug in the equation where mass and power are being #218
Open
DimitriDiantos pushed a commit that referenced this issue Mar 6, 2024
Task #206 Add my name in the author's list.
33ce018
DimitriDiantos pushed a commit that referenced this issue Mar 6, 2024
Task #206 correction of the detecting error from the mass.
c42c0e9
DimitriDiantos pushed a commit that referenced this issue Mar 14, 2024
Task #206 updating of the concept.concept and restore the destroyed
b95ead9 
files.
DimitriDiantos pushed a commit that referenced this issue Mar 15, 2024
Task #206 Fix the error of the calculation.
fb05cbb
DimitriDiantos pushed a commit that referenced this issue Mar 20, 2024
Task #206 fix the errors.
7e534b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitriDiantos DimitriDiantos

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@DimitriDiantos @dellerDLR