Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] filterCategories is marked as required in DataFilterExtensionProps type #9494

Open
2 of 7 tasks
mz8i opened this issue Mar 4, 2025 · 0 comments · May be fixed by #9495
Open
2 of 7 tasks

[Bug] filterCategories is marked as required in DataFilterExtensionProps type #9494

mz8i opened this issue Mar 4, 2025 · 0 comments · May be fixed by #9495
Labels

Comments

@mz8i
Copy link
Contributor

mz8i commented Mar 4, 2025

Description

The type DataFilterExtensionsProps contains:

  /**
   * The categories which define whether an object should be rendered.
   * @default []
   */
  filterCategories: FilterCategory[] | FilterCategory[][];

which is inconsistent with the docs and, I believe, unintentional.

Flavors

  • Script tag
  • React
  • Python/Jupyter notebook
  • MapboxOverlay
  • GoogleMapsOverlay
  • CARTO
  • ArcGIS

Expected Behavior

The filterCategories prop should be marked as optional in TS.

Steps to Reproduce

N/A

Environment

  • Framework version: 9.1.4
  • Browser: N/A
  • OS: N/A

Logs

No response

@mz8i mz8i added the bug label Mar 4, 2025
@mz8i mz8i linked a pull request Mar 4, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant