-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to data-resources block in WP #1337
Comments
Hi @mshujamalik-ebi, could you please provide the relevant CH queries for this one? |
Hi @mshujamalik-ebi, thanks for the examples! Search by keywords doesn't seem to work. For example: Also can't see any difference between long and short description: The above output diffferent results but the description doesn't seem to be affected. Or is it supposed to work like this? |
also it seems that sorting |
@mshujamalik-ebi @kasprzyk-sz I guess there is confusion with the long/short description requirement - We don't need any search option for description, the requirement is to show or hide long/short descriptions in the block or which description to use for display they can use long or they can use short description for display. E.g below screenshot - by default currently it takes long description, so we need to give option in block to choose. |
Thanks for clarifying @sandykadam . Shouldn't the query be then something like |
You can hide the field by hide flag, @mshujamalik-ebi give him example of show/hide field for description. @kasprzyk-sz similar to how we do for profile block where we can show hide position/phone etc |
@kasprzyk-sz To hide the description we have this : Thanks |
Thanks! @mshujamalik-ebi could you look into keyword search and sorting? @sandykadam should it be possible to combine the parameters like search by title AND team or search by title OR team? |
@kasprzyk-sz The sorting is done on changed DESC by default,if you try ASC then it changes the result. |
Many thanks @mshujamalik-ebi! For the sorting, is it supposed to be sorted alphabetically based on the title? @sandykadam does it make sense to keep the keyword search then? |
search by title, keyword should be OR like dropdown and team should be separate @kasprzyk-sz also use "EMBL Teams" taxonomy to populate teams dropdown, so user can select team from dropdown and you can pass the team ID to API, @mshujamalik-ebi will give you example on how to use BDR ID to be used in pattern html of data-resources Below is screenshot of ID which we already storing in "EMBL Teams" taxonomy. |
Hi @kasprzyk-sz
We need to make following modifications to data-resources block to make it flexible for editors.
Option to
@kasprzyk-sz please also add documentation & steps on https://stable.visual-framework.dev/wordpress/blocks/
@mshujamalik-ebi please note this and accordingly make necessary changes to CH API and provide examples to Szymon so he will implement the changes accordingly.
FYI @Adedoyinebi
The text was updated successfully, but these errors were encountered: