Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sys - Merge latest quill #107

Closed
garv-shah opened this issue Aug 2, 2022 · 2 comments
Closed

Sys - Merge latest quill #107

garv-shah opened this issue Aug 2, 2022 · 2 comments
Labels
closed Either incomplete specs, irrelevant, or not going to do

Comments

@garv-shah
Copy link

It seems like Flutter Quill has had a lot more activity recently, and quite a few features that this repo has yet to implement. Would it be worth trying to pull from the original package?

@garv-shah garv-shah closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2022
@garv-shah
Copy link
Author

thanks for the chat on discord!

@adrian-moisa
Copy link
Collaborator

adrian-moisa commented Aug 2, 2022

Glad to be of service! I'll drop here the summary:

No, it's not possible to just pull straight away. But for someone with some experience in one or the other it would be possible to retrofit. I've been watching to see the updates. Some of them were planned here as well. Neither upstream or downstream is easy. I've changed the underlying project structure by a large factor. The only way this would work is if they ditch everything changed since this repo started.

The reason I decided to fork was simply because I had no reliable connection with the maintainer and since I needed major changes in the code base I couldn't rely on his good will to respond in timely fashion. Also I'm not really happy at all with their quality practices. This repo will grow in time. Don't stress too much about large numbers of stars on github. As long as the code has a dedicated lead that keeps pushing it further it's safe to use. For me this repo is critical for my startup, there's no going back.

All I can tell you is that I've invested massive effort to get VE onto a new direction. And there will be YT videos upcoming. These are ready for voice over. At the moment they are pending because I'm overloaded, but I'll find some time to do the voice over and start releasing them. There will be effort to add automatic testing, online docs and demos. All in all in time this repo will gain a following

unknown

This is Quill:

unknown-1

This is VE:

unknown-2

Lines of code AVG from 263 down to 98. From 71 files up to 223. It's a plugin for Android Studio called Statistic. That alone tells you a lot of effort was placed into making the code base far more readable. I'll be happy to support you at implementing formulas using latex.

Join on discord to get advice and help or follow us on YouTube Visual Coding to learn more about the architecture of Visual Editor and other Flutter apps.

@adrian-moisa adrian-moisa changed the title Pull from Upstream? Sys - Merge latest quill (not doable) Nov 5, 2022
@adrian-moisa adrian-moisa added MVP and removed MVP labels Nov 5, 2022
@adrian-moisa adrian-moisa changed the title Sys - Merge latest quill (not doable) Sys - Merge latest quill Nov 6, 2022
@adrian-moisa adrian-moisa added the closed Either incomplete specs, irrelevant, or not going to do label Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed Either incomplete specs, irrelevant, or not going to do
Projects
None yet
Development

No branches or pull requests

2 participants